437256 - Error message when adding vouchers to CVS accounts

Status: RESOLVED FIXED

(Webtools Graveyard :: Despot, defect)

Description

[Marcia Knous [:marcia]]

Today I tried to add Mitchell as a voucher for Tiffney, and I used her .com address. When I tried to change to the .org address, I get an error message. I then tried to use my email address and received the same error. So basically now I cannot add a voucher without getting an error message.

Comment 1

[Reed Loden [:reed]]

What is the error?

Comment 2

[Marcia Knous [:marcia]]

Can't change email to '[e-mail]'; already used.

Please hit back and try again.

Comment 3

[Reed Loden [:reed]]

Something is wrong in this block of code:

    foreach my $field ("email", "voucher") {
        my $value = param($field);
        if ($value ne param("orig_$field")) {
            if ($field == "email") {
                my $query = $::db->prepare("SELECT COUNT(*) FROM users WHERE email = ?");
                $query->execute($value);
                my @row;
                @row = $query->fetchrow_array();
                if ($row[0] > 0) {
                   Punt("Can't change email to '$value'; already used.");
                }
            }
            elsif ($field == "voucher") {
                # EmailToId() will Punt() if the voucher is not valid.
                $value = EmailToId($value, 1);
            }
        }
    }

I think it's in the use of |my| here... basically, attempting to change the voucher results in the "Can't change email to" Punt(), which should be only for when the email is changed.

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v1

n00b perl mistake :(

Comment 5

[timeless]

Comment on attachment 332682 [details] [diff] [review]
patch - v1

:(... my fault for not catching it... it was even visible in context.

Comment 6

[Reed Loden [:reed]]

Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.61; previous revision: 1.60
done