43730 - Extra horizontal bar (Classic)

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Henri Sivonen (:hsivonen)]

Classic theme, build 2000062408

There is a six-pixel-high horizontal bar between the bookmark toolbar and the content 
area.

What is the purpose of that bar? It looks unnecessary and uses screen real-estate. Could 
it be removed?

Comment 1

[Henri Sivonen (:hsivonen)]

Reassigning to Ben.

Comment 2

[Jan Varga [:janv]]

Attachment: this patch should fix bugs: 43730 43735 43734

Comment 3

[Jan Varga [:janv]]

adding myself to CC list

Comment 4

[Matthew T (active 1999-2002)]

Adding dependencies, which should be deleted if this patch turns out to have 
something wrong with it.

Comment 5

[Blake Ross]

Umm.  Unless I'm mistaken (and don't know what you're referring to), that bar 
is deliberate, and is intended to give a 3D look.  IE has the same thing.  Or 
this is some mac-specific problem?  Could you attach a screenshot, please?

Comment 6

[timeless]

would someone please attach a screen capture containing the following:
a. Relevant region of screen w/ red circling or pointing at the specific area.
b. Mock up of what you think should be there instead.
I'm guessing that Classic is actually emulating ie instead of moz in this.  And 
because of the way we're drawing bars I think we have to.  I would not be 
surprised if Ben marks this WONTFIX.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: The unnecessary bar masked red

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: The unnecessary bar erased

Comment 9

[Blake Ross]

I'm pretty sure that's deliberate. Your screenshots don't help because by 
making it red, I can't see what it really looks like.  Just circle it...

Comment 10

[Henri Sivonen (:hsivonen)]

Attachment: The unnecessary bar within an unevenly scaled circle

Comment 11

[Henri Sivonen (:hsivonen)]

I don't the bar got there by accident. Still, I don't see the bar serving any useful purpose.

Comment 12

[timeless]

Attachment: This is probably what we're emulating.

Comment 13

[Matthew T (active 1999-2002)]

Emulating IE's little bar makes a small amount of sense, if one or more of the 
following are true:
* you can get it to intersect properly with the window borders (so it looks like
  part of the same piece of piping)
* the throbber is as tall as the topmost toolbar, in which case you need
  something to provide padding between the bottom of the throbber and the top of
  the content
* the bar can be dragged down to produce a window with two panes.

But none of these are true, so the bar should go.

Comment 14

[Henri Sivonen (:hsivonen)]

This is fixed on Mac. Is the bar gone on other platforms, too?

Comment 15

[Blake Ross]

Gone in windows...

Comment 16

[Jan Varga [:janv]]

Still visible on Linux

Comment 17

[Henri Sivonen (:hsivonen)]

Changing OS/Platform accordingly.

Comment 18

[Jan Varga [:janv]]

Ben just made Unix build the windows skin
I don't see extra horizontal bar anymore

Comment 19

[Henri Sivonen (:hsivonen)]

Marking fixed because of comments.

Comment 20

[Alex]

verified gone on linux, please verify on mac and windows

Comment 21

[Matthew T (active 1999-2002)]

Verified fixed, build 2000121514, Mac OS 9.0.