437397 - change pushlog hook to use sqlite

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: hghooks patch

I've rewritten the hg pushlog hook to use a sqlite database for storage, and written a converter script from the old flat file format. I haven't tested this on a CentOS system, only on my Mac, so I'm a little worried about the right sqlite package being available, but I can probably work around that if need be.

Pushlog feed changes to follow in a separate bug.

Comment 1

[Benjamin Smedberg]

Comment on attachment 323864 [details] [diff] [review]
hghooks patch

>+def log(ui, repo, node, **kwargs):
>+    pushdb = os.path.join(repo.path, 'pushlog.db')
>+    createdb = False
>+    if not os.path.exists(pushdb):
>+        createdb = True
>+    conn = sqlite.connect(pushdb)
>+    if createdb:
>+        createpushdb(conn)
>+    d = datetime.utcnow().replace(microsecond=0)
>+    conn.execute("INSERT INTO pushlog (node, user, date) values(?,?,?)",
>+                 (node, os.environ['USER'], d.isoformat()+"Z"))
>+    conn.commit()

The python hooks documentation says that hooks should "return False" to indicate success.

Other than that, this looks good!

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 323864 [details] [diff] [review]
hghooks patch

The RFEs I had should probably work fine on this, too.

Comment 3

[(not currently active) Ted Mielczarek]

Pushed to bsmedberg's hghooks repo. Will file a followup on getting this installed, once I get the web bits done.