[id] installer/overrides.properties newline cleanup

RESOLVED FIXED

Status

Mozilla Localizations
id / Indonesian
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Pike, Unassigned)

Tracking

({fixed1.9.0.1})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
In http://mxr.mozilla.org/l10n/search?string=FileError&find=[beimru][deku]%2Fbrowser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n and http://mxr.mozilla.org/l10n/search?string=FileError&find=[ez][sh]-[EC].%2Fbrowser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n, the original markup of the newlines in the error messages got mangled and changed.

I don't see this as a release blocker, as apparently preprocess-locale.pl does 'something', but the newline combo should really look like en-US, i.e., \r\n\r\n$0\r\n\r\n and \r\n elsewhere.

This affects both FileError and FileError_NoIgnore.

Please attach a patch and request approval1.9 to include this in a future 3.0.x release.

Comment 1

10 years ago
Created attachment 324184 [details] [diff] [review]
the patch
Attachment #324184 - Flags: approval1.9?
(Reporter)

Comment 2

10 years ago
Comment on attachment 324184 [details] [diff] [review]
the patch

a=me, please land this with a check-in comment referencing this bug and my approval. Something like "bug 324184, fix newlines, a=l10n@mozilla.com" would work.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Please cancel the approval1.9 flag, too.
Attachment #324184 - Flags: approval1.9.0.1+
(Reporter)

Comment 3

10 years ago
Comment on attachment 324184 [details] [diff] [review]
the patch

I can actually cancel myself ;-)
Attachment #324184 - Flags: approval1.9?

Comment 4

10 years ago
Landed.

Checking in id/browser/installer/override.properties;
/l10n/l10n/id/browser/installer/override.properties,v  <--  override.properties
new revision: 1.3; previous revision: 1.2
done

Thanks Axel
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.9.0.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.