437409 - [mk] installer/overrides.properties newline cleanup

Status: RESOLVED FIXED

(Mozilla Localizations :: mk / Macedonian, defect)

Description

[Axel Hecht [:Pike]]

In http://mxr.mozilla.org/l10n/search?string=FileError&find=[beimru][deku]%2Fbrowser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n and http://mxr.mozilla.org/l10n/search?string=FileError&find=[ez][sh]-[EC].%2Fbrowser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n, the original markup of the newlines in the error messages got mangled and changed.

I don't see this as a release blocker, as apparently preprocess-locale.pl does 'something', but the newline combo should really look like en-US, i.e., \r\n\r\n$0\r\n\r\n and \r\n elsewhere.

This affects both FileError and FileError_NoIgnore.

Please attach a patch and request approval1.9 to include this in a future 3.0.x release.

Comment 1

[Damjan Georgievski]

Attachment: override.properties.patch

here's the patch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 326470 [details] [diff] [review]
override.properties.patch

a=me, please land this with a check-in comment referencing this bug and my approval, something like "bug 437409, fix line breaks, a=[e-mail]" would do.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Comment 3

[Damjan Georgievski]

landed in cvs