Closed Bug 437422 Opened 16 years ago Closed 16 years ago

Automate litmus test for testing search and clear list

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1a2

People

(Reporter: sdwilsh, Assigned: poonaatsoc)

References

Details

Attachments

(1 file, 3 obsolete files)

v3.1
7.34 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review 
This should be a chrome test that lives in toolkit/mozapps/downloads/tests/chrome/ to replace this litmus test:
https://litmus.mozilla.org/show_test.cgi?id=5285
Blocks: 442327
No longer blocks: gsoc
Attached patch v1.0 (obsolete) — — Splinter Review 

        Attachment #328286 -
        Flags: review?(sdwilsh)

    
    

    
  
Comment on attachment 328286 [details] [diff] [review]
v1.0

This file suffers from lots of the same things mentioned in bug 443585 comment 2.  Please fix and make a new attachment.

        Attachment #328286 -
        Flags: review?(sdwilsh) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2.0 (obsolete)
        — 
          — Splinter Review
      

    


  
Tested.  Passes.

        Attachment #328286 -
        Attachment is obsolete: true

        Attachment #330815 -
        Flags: review?(sdwilsh)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v3.0 (obsolete)
        — 
          — Splinter Review
      

    


  
Test updated to accommodate the new utils.js.  The test passes

        Attachment #330815 -
        Attachment is obsolete: true

        Attachment #331482 -
        Flags: review?(sdwilsh)

        Attachment #330815 -
        Flags: review?(sdwilsh)

    
    

    
  
Comment on attachment 331482 [details] [diff] [review]
v3.0

This test doesn't quite do what the litmus tests does.  I've fixed it.  Uploading shortly.

        Attachment #331482 -
        Flags: review?(sdwilsh) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v3.1
        — 
          — Splinter Review
      

    


  
Fixes the test and addresses review comments

        Attachment #331482 -
        Attachment is obsolete: true

        Attachment #331528 -
        Flags: review+

    
    

    
  
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/46e2648da0fc

Stephen - you can now disable this litmus test :)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2

    
    

    
  
Litmus test disabled; w00t! (Thanks guys!)
Product: Firefox → Toolkit

    
    

    
  
stephen: Based on Comment 8, I assume we can remove the in-Litmus? flag which is currently set in this bug?

    
    

    
  
(In reply to comment #9)
> stephen: Based on Comment 8, I assume we can remove the in-Litmus? flag which
> is currently set in this bug?

Yup; done, thanks!
Flags: in-litmus? → in-litmus-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: