43755 - File properties tab suggestions

Status: VERIFIED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[pete]

I think the tabs in the file properties are actually buttons instead of real 
tabs.

Comment 1

[Asa Dotzler [:asa]]

[e-mail] (JakieChan), I don't understand this report at all.  Can you 
please explain the bug more.

Comment 2

[pete]

What I'm saying is, http://www.mozilla.org/xpfe/xulref/boxref.html says 
the "vertical" or "horizontal" values for the align attribute are depreciated 
and suggests to use orient attribute for this instead. However, tabcontrol.css 
uses align="vertical" align="horizontal" to decide how to render the tabs to 
make them look like tabs and not buttons. Since I can't find an xul.dtd I do 
not know for sure which values are default for properties. Anyways, as you can 
see the tabs in the bookmarks property sheet do not render looking like a tab 
because it doesn't list the alignment according to tabcontrol.css. This also 
happens in all the places I've bothered looking for that uses <tab> but bm-
props.xul is where I noticed this first.

Comment 3

[Asa Dotzler [:asa]]

adding ben and rjc to the bug.

Comment 4

[Chris McAfee]

m19

Comment 5

[Asa Dotzler [:asa]]

with a milestone set, confirming.

Comment 6

[Blake Ross]

Reassigning 79 Bookmarks bugs to Ben.  I was told this was going to be done 
shortly about two months ago, but it clearly hasn't been.  I think that's long 
enough for all these bugs to remain assigned to nobody.

Feel free to filter all this spam into the trashcan by looking for this string 
in the message body: ducksgoquack

Comment 7

[Matthew Wilson]

The tabs in the bookmark properties sheet look like tabs to me... 

bm_props.xul:
<tabcontrol orient="vertical">
  <tabbox>
    <tab value="&generalInfo.label;" accesskey="&generalInfo.accesskey;"/>
    <tab id="ScheduleTab" value="&schedule.label;" 
accesskey="&schedule.accesskey;"/>
  </tabbox>
  <tabpanel>

etc.

Is this invalid?

Comment 8

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is not a Netscape beta stopper.

Comment 9

[James Green]

If this is a bookmarks issue, is it still relevent following Ben's re-write of
Bookmarks in recent weeks? Adding qawanted keyword.

Comment 10

[Claudius Gayle]

this looks like a WFM based on Matthew's comments and looking at the 2001030608 builds

Comment 11

[Claudius Gayle]

with reckless disregard to independent verification (and b/c I'm pretty sure) marking
VERIFIED WFM

Comment 12

[sairuh (rarely reading bugmail)]

mass-verifying WorksForMe bugs which haven't changed since 2001.12.31.

set your search string in mail to "EmperorLondoMollari" to filter out these
messages.