437602 - importxml.pl does not correctly build the bugs_fulltext table

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Ed Goose]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705; InfoPath.1; .NET CLR 1.1.4322; MS-RTC LM 8; .NET CLR 2.0.50727)
Build Identifier: 

When running an import by xml using the importxml.pl script, the _sync_fulltext function does not pass 'new_bug', therefore, the bug is assumed to exist and the only part of sync_fulltext called is the update. As the bug doesn't exist, the update fails (with no error) because the insert hasn't been called beforehand.

Reproducible: Always

Steps to Reproduce:
1. Import a bug using the importxml.pl script.
2. Check the bug imported correctly.
Actual Results:  
The bugs_fulltext table is not populated for this new bug.

Expected Results:  
The bugs_fulltext table should be populated for this bug.

Comment 1

[Ed Goose]

Attachment: Patch v1 for importxml.pl

Assumes that all bugs imported are new - I assume this is correct?

Comment 2

[Frédéric Buclin]

Comment on attachment 324022 [details] [diff] [review]
Patch v1 for importxml.pl

Nice catch. r=LpSolit

Comment 3

[Frédéric Buclin]

This makes me think: sanitycheck.cgi should now make sure that bugs_fulltext contains an entry for each bug listed in the bugs table. All imported bugs currently have no entry due to the bug reported here, meaning that searching for them will fail (no result).

If sanitycheck doesn't do this check yet, we should fix it (maybe in a separate bug).

Comment 4

[Frédéric Buclin]

Yet another fix required: checksetup.pl should populate bugs_fulltext itself, and not only when this table is empty (as _populate_bugs_fulltext() currently does).

Comment 5

[Ed Goose]

Yes, thats what caused me to find this problem, we we're running searches and getting no results. 

I'm afraid I haven't played around with checksetup myself, so I'm not 100% sure how to go about this one. I think it would be best as another separate bug.

Comment 6

[Frédéric Buclin]

tip:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.83; previous revision: 1.82
done

3.1.4:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.82.2.1; previous revision: 1.82
done