Make "type" a method of Bugzilla::WebService

RESOLVED FIXED in Bugzilla 3.4

Status

()

--
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

3.1.4
Bugzilla 3.4
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Instead of calling SOAP::Data->type everywhere, we should be able to call $self->type() as a method of Bugzilla::WebService. This would also make it easier to auto-format datetimes and extend the webservice with other frontends (which is the main reason I'm doing it).
(Assignee)

Comment 1

10 years ago
Created attachment 324038 [details] [diff] [review]
v1

I've tested this and it works fine.
Assignee: webservice → mkanat
Status: NEW → ASSIGNED
Attachment #324038 - Flags: review?(wurblzap)
This seems not to work for me for some reason. I suspect it's something wrong with my setup here, though. I'm looking into it.
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> This seems not to work for me for some reason. I suspect it's something wrong
> with my setup here, though. I'm looking into it.

  Might be related to SOAP::Lite version, too. If it's not just setup (does it work without the patch?), let me know what SOAP::Lite you have.
(Assignee)

Comment 4

10 years ago
Hey Wurblzap. Any updates on this?
(Assignee)

Comment 5

10 years ago
Comment on attachment 324038 [details] [diff] [review]
v1

dkl, do you think you could review this?

I might need to update it for some of the recent WebService changes.
Attachment #324038 - Flags: review?(wurblzap) → review?(dkl)
(Assignee)

Comment 6

10 years ago
Created attachment 327284 [details] [diff] [review]
v2

Yeah, it needed updating.
Attachment #324038 - Attachment is obsolete: true
Attachment #327284 - Flags: review?(dkl)
Attachment #324038 - Flags: review?(dkl)

Comment 7

10 years ago
Comment on attachment 327284 [details] [diff] [review]
v2

Pacth looks good. Tested and works as expected.
Attachment #327284 - Flags: review?(dkl) → review+
(Assignee)

Updated

10 years ago
Flags: approval+
(Assignee)

Comment 8

10 years ago
Checking in Bugzilla/WebService.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService.pm,v  <--  WebService.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.15; previous revision: 1.14
done
Checking in Bugzilla/WebService/Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.8; previous revision: 1.7
done
Checking in Bugzilla/WebService/Product.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Product.pm,v  <--  Product.pm
new revision: 1.6; previous revision: 1.5
done
Checking in Bugzilla/WebService/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/User.pm,v  <--  User.pm
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
You need to log in before you can comment on or make changes to this bug.