Closed Bug 437646 Opened 16 years ago Closed 16 years ago

make use of :nth-child in the download list, remove stripeifyList()

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
      No description provided.
Attachment #324066 - Flags: review?(sdwilsh)
Summary: make use of :nth-child in the downloads list, remove stripeifyList() → make use of :nth-child in the download list, remove stripeifyList()
Comment on attachment 324066 [details] [diff] [review]
patch

purdy

r=sdwilsh
Attachment #324066 - Flags: review?(sdwilsh) → review+
Keywords: checkin-needed
hrm - I'm just ran the tests with this patch applied, and I'm not seeing the colors being applied like before.
What exactly is different? Is the background color missing entirely?
Keywords: checkin-needed
Yeah, I saw no striping whatsoever.  The tests are in toolkit/mozapps/downloads/test/browser now, but will be moved to chrome tests soon in bug 437302.
The richlistitem[type="download"]:not([selected="true"]):nth-child(odd) selector itself should be fine, I tested this on Windows. I still can't test on OS X currently, but I'll take another look at Linux.
I don't recall windows doing any stripeifying, so it shouldn't show up that way on windows.
Yep, I added it just to serve the testing purpose.
Maybe I didn't rebuild properly.  It's working for me now.  I'll push this once central opens.
Keywords: checkin-needed
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/7c2306a92f89
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Flags: in-litmus?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: