437646 - make use of :nth-child in the download list, remove stripeifyList()

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 324066 [details] [diff] [review]
patch

purdy

r=sdwilsh

Comment 2

[Shawn Wilsher :sdwilsh]

hrm - I'm just ran the tests with this patch applied, and I'm not seeing the colors being applied like before.

Comment 3

[Dão Gottwald [:dao]]

What exactly is different? Is the background color missing entirely?

Comment 4

[Shawn Wilsher :sdwilsh]

Yeah, I saw no striping whatsoever.  The tests are in toolkit/mozapps/downloads/test/browser now, but will be moved to chrome tests soon in bug 437302.

Comment 5

[Dão Gottwald [:dao]]

The richlistitem[type="download"]:not([selected="true"]):nth-child(odd) selector itself should be fine, I tested this on Windows. I still can't test on OS X currently, but I'll take another look at Linux.

Comment 6

[Shawn Wilsher :sdwilsh]

I don't recall windows doing any stripeifying, so it shouldn't show up that way on windows.

Comment 7

[Dão Gottwald [:dao]]

Yep, I added it just to serve the testing purpose.

Comment 8

[Shawn Wilsher :sdwilsh]

Maybe I didn't rebuild properly.  It's working for me now.  I'll push this once central opens.

Comment 9

[Shawn Wilsher :sdwilsh]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/7c2306a92f89