Closed
Bug 437646
Opened 16 years ago
Closed 16 years ago
make use of :nth-child in the download list, remove stripeifyList()
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
3.64 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #324066 -
Flags: review?(sdwilsh)
Assignee | ||
Updated•16 years ago
|
Summary: make use of :nth-child in the downloads list, remove stripeifyList() → make use of :nth-child in the download list, remove stripeifyList()
Comment 1•16 years ago
|
||
Comment on attachment 324066 [details] [diff] [review] patch purdy r=sdwilsh
Attachment #324066 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 2•16 years ago
|
||
hrm - I'm just ran the tests with this patch applied, and I'm not seeing the colors being applied like before.
Assignee | ||
Comment 3•16 years ago
|
||
What exactly is different? Is the background color missing entirely?
Keywords: checkin-needed
Comment 4•16 years ago
|
||
Yeah, I saw no striping whatsoever. The tests are in toolkit/mozapps/downloads/test/browser now, but will be moved to chrome tests soon in bug 437302.
Assignee | ||
Comment 5•16 years ago
|
||
The richlistitem[type="download"]:not([selected="true"]):nth-child(odd) selector itself should be fine, I tested this on Windows. I still can't test on OS X currently, but I'll take another look at Linux.
Comment 6•16 years ago
|
||
I don't recall windows doing any stripeifying, so it shouldn't show up that way on windows.
Assignee | ||
Comment 7•16 years ago
|
||
Yep, I added it just to serve the testing purpose.
Comment 8•16 years ago
|
||
Maybe I didn't rebuild properly. It's working for me now. I'll push this once central opens.
Keywords: checkin-needed
Comment 9•16 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/7c2306a92f89
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Flags: in-litmus?
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → Firefox 3.1a1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•