437647 - Set up dispatch mechanism for multiple dehydra/treehydra scripts

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Attachment: Dispatch analyses

As we add additional dehydra/treehydra scripts, we need to stop having everything be process_tree or process_function. For lack of an automatic dispatch mechanism, I have a manual mechanism which will dispatch process_tree to outparams_process_tree as well as other analyses we add (e.g. XPCOMGC finalizers, SQL analysis, etc)

Comment 1

[(dormant account)]

As an idea, we could use namespaces for this.
let treehydra_scripts = []
let treehydra_sql = {}
include('sql.js', treehydra_sql)
treehydra_scripts.push(treehydra_sql)
...

Then dispatch is a matter of 
for each (script in treehydra_scripts)
 script.process_tree(...)

Comment 2

[Benjamin Smedberg]

I tried to make this work, but it doesn't: when you do the include, the global object doesn't have any of the normal functions (iter, treehydra.js stuff etc), so it just doesn't work.

Comment 3

[Benjamin Smedberg]

Attachment: Dispatch analyses, without hardcoding

This imports each analysis into its own global object and dispatches the callbacks to each one independently.

Comment 4

[David Mandelin [:dmandelin]]

Comment on attachment 324091 [details] [diff] [review]
Dispatch analyses, without hardcoding

Looks great. If there's some problem with include_path, feel free to file it so we can fix it.

Comment 5

[Benjamin Smedberg]

Pushed to mozilla-central, revision 5cd633865e6d