437922 - build error in prmjtime.cpp with mingw

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Mook]

Attachment: use PR_MAX

See URL.

max() isn't defined in mingw/w32api in C++ (it has an explicit #ifndef __cplusplus), presumably because the macro would screw with things like numeric_limits::max().  PR_MAX should be used here instead.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 324246 [details] [diff] [review]
use PR_MAX

r-: need to use JS_MAX, though I wonder why mingw has that rule for max and other environments seem not to?

Comment 2

[:Mook]

Attachment: use JS_MAX

thanks for catching my idiocy, shaver :)  let's try these other two characters instead... (still builds)

Comment 3

[:Mook]

Attachment: refresh patch to m-c head [Checkin: Comment 4]

... maybe I should try again?  Nothing's materially changed in the patch.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 363523 [details] [diff] [review]
refresh patch to m-c head
[Checkin: Comment 4]


http://hg.mozilla.org/mozilla-central/rev/6410c3cdd64f

Comment 5

[Bob Clary [:bc] (inactive)]

Serge is my hero! Thanks for the -.