437941 - Task-Trees: Selection Style does not make a difference between focused/unfocused

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

Currently selcted tree items of the task trees always have the same background-color no matter if they are focused or not focused. This is bad for the buttons that perform their action on the focused pane like the "delete" or "copy" button, because the user does not have a focus-feedback from the task-tree.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

This should improve the situation. I will ask for review as soon as bug 429685 is integrated.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 324260 [details] [diff] [review]
patch v. #1

>+treechildren::-moz-tree-row(selected) {
>+  background-color: -moz-Dialog;
> }
Quite a general rule, is that needed? Or can it be .calendar-task-tree > treechildren...

Also, does this bug need ui-r, or was that what you were discussing with Christian yesterday? I'm not quite sure moz-dialog is the right color for selected rows. Doesn't this make the row gray on windows? afaik selected, unfocused rows have a transparent background and a dotted border?


r=philipp for the code

Comment 3

[Pete Riley]

If it helps, I think that Thunderbird uses the styles in C:\Program Files\Thunderbird\Chrome\classic.jar\skin\classic\global\tree.css.

Comment 4

[Berend Cornelius]

removed the dispensible rules as philipp proposed and checked in patch on trunk and MOZILLA_1_8_BRANCH

->Fixed

Comment 5

[Berend Cornelius]

>Also, does this bug need ui-r, or was that what you were discussing with
>Christian yesterday? 

No I talked with Christian about this and Christian considered this a mere bug with no need for a ui-request.

Comment 6

[Stefan Sitter [:ssitter]]

Seems this fix introduced Bug 351145 for the task list too.

Comment 7

[Andreas Treumann]

Checked in lightning build 20061918 and sunbird 20080619 -> VERIFIED.