438284 - Remove misleading and wrong translation note from profileSelection.properties

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Axel Hecht [:Pike]]

profileSelection.properties says

# LOCALIZATION NOTE: Do not translate <html:br/>

which is apparently confusing (see bug 438065), in particular as there isn't any br in the whole file since at least 2004.

We should remove it, on central and probably the 1.9 branch, too.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch (based on m-c rev 09b605eb3e0d)

Requesting approval for 2.0, 1.9.2.18 and 1.9.1.20 per comment 0.

No risk; only removes an incorrect localisation comment.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 525010 [details] [diff] [review]
Patch (based on m-c rev 09b605eb3e0d)

Please wait until the patch is reviewed and landed before requesting approval though to be honest I wouldn't even bother trying to put this onto the branches.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 525010 [details] [diff] [review]
Patch (based on m-c rev 09b605eb3e0d)

r=me, but needs a toolkit reviewer, still.

I agree that this doesn't need to go on branches, central is good enough.

Comment 4

[Ed Morley [:emorley]]

Thanks for the speedy review / sorry for the unnecessary a? request.

Comment 5

[(no longer active)]

http://hg.mozilla.org/projects/cedar/rev/0f251ed10192

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0f251ed10192

Comment 7

[Ed Morley [:emorley]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/profile/profileSelection.properties#1
...line 1, no longer a(n incorrect) localisation note.

-> Verified