Blocklist should not contain null match elements

RESOLVED FIXED in 3.4.3

Status

addons.mozilla.org Graveyard
Developer Pages
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: morgamic, Assigned: morgamic)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
If name, description or filename are null in the blplugins table, the output should not contain match elements without exp values.

For example:
<match name="name" exp=""/>

or
<match name="name"/>

Are both invalid and cause mixed results (mostly false negatives).
(Assignee)

Comment 1

10 years ago
Created attachment 324536 [details] [diff] [review]
v1, adds proper support for null match elements

This adds checking for null match values.  If the values in the database are NULL, the corresponding match elements will not be printed in the resulting XML with a null or empty exp="" element.
Assignee: nobody → morgamic
Status: NEW → ASSIGNED
Attachment #324536 - Flags: review?(clouserw)
(Assignee)

Updated

10 years ago
Blocks: 430826
(Assignee)

Comment 2

10 years ago
Created attachment 324539 [details] [diff] [review]
v2, sorry i left out the test sql
Attachment #324536 - Attachment is obsolete: true
Attachment #324539 - Flags: review?(clouserw)
Attachment #324536 - Flags: review?(clouserw)

Updated

10 years ago
Attachment #324539 - Flags: review?(clouserw) → review+
(Assignee)

Comment 3

10 years ago
r15267
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.