438428 - Blocklist should not contain null match elements

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Michael Morgan [:morgamic]]

If name, description or filename are null in the blplugins table, the output should not contain match elements without exp values.

For example:
<match name="name" exp=""/>

or
<match name="name"/>

Are both invalid and cause mixed results (mostly false negatives).

Comment 1

[Michael Morgan [:morgamic]]

Attachment: v1, adds proper support for null match elements

This adds checking for null match values.  If the values in the database are NULL, the corresponding match elements will not be printed in the resulting XML with a null or empty exp="" element.

Comment 2

[Michael Morgan [:morgamic]]

Attachment: v2, sorry i left out the test sql

Comment 3

[Michael Morgan [:morgamic]]

r15267