438532 - signons2.txt -> signons3.txt migration looses saved passwords

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Török Edwin]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9) Gecko/2008060906 Iceweasel/3.0 (Debian-3.0~rc2-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9) Gecko/2008060906 Iceweasel/3.0 (Debian-3.0~rc2-1)

Login/password are no longer filled in automatically for some sites with Firefox 3. They don't show up in show passwords either.
If I downgrade to Firefox 2 the passwords are automatically filled in again.

Comparing signons3.txt with signons2.txt I see that 8 sites are missing, for example:
https://bugs.freedesktop.org
http://sourceforge.net
http://sourceware.org
https://www.securecoding.cert.org
...

Reproducible: Always

Steps to Reproduce:
1. Create a login on one of the example sites above (https://bugs.freedesktop.org) using Firefox 2
2. Verify that Firefox 2 fills in login/password automatically
2. Install Firefox 3
3. Go to https://bugs.freedesktop.org
Actual Results:  
login/password in not filled in automatically
login/password for site is not in show passwords list.

Expected Results:  
login/password to be filled in automatically, and available in show passwords list

I can't show you the contents of signons2.txt since its not encrypted, but here is the portion without the password (replaced with ....), #2d is at the beginning of the file:

#2d
http://localhost:8080
https://www.google.com
.
https://bugs.freedesktop.org
Bugzilla_login
ME....
*Bugzilla_password
MD....
https://bugs.freedesktop.org
.
http://ac.ahost.ro

This entry is completely missing from signons3.txt:
#2e
http://localhost:8080
https://www.google.com
http://192.168.0.1
.
http://ac.ahost.ro

This command shows 8 missing hosts, maybe you could run a sanity check after converting the passwords to check that all have been converted?

$ grep http signons2.txt |sort -u >list2
$ grep http signons3.txt |sort -u >list3
$ diff -w list2 list3|diffstat
 unknown |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

[the insertions are because I registered on this bugzilla, and another one in the meantime]

Since passwords are lost in the conversion, I set the severity to critical: causes you to lose data. 
The data isn't actually lost, downgrading to Firefox 2 still allows me to use it.

Comment 1

[Justin Dolske [:Dolske]]

Please attach some debugging from http://wiki.mozilla.org/Firefox:Password_Manager_Debugging...

1) enable the debugging
2) quit the browser
3) delete signons3.txt (it will reimport from signons2.txt)

Comment 2

[Török Edwin]

(In reply to comment #1)
> Please attach some debugging from
> http://wiki.mozilla.org/Firefox:Password_Manager_Debugging...
> 
> 1) enable the debugging
> 2) quit the browser
> 3) delete signons3.txt (it will reimport from signons2.txt)
> 

I removed signons3.txt, firefox reimported the passwords and now all the passwords are there.
I did try an early -rc of firefox 3.0 a while ago, I deleted it, but signons3.txt was probably left behind.

I repeated the reimport of signons, and each time it was correctly imported, so I think the current version of firefox 3.0 is fine, and it was an earlier -rc that incorrectly imported the passwords data.