438601 - Missing buttons for adding a security exception

Status: RESOLVED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Saša Bodiroža]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008060720 Firefox/3.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008060720 Firefox/3.0

The buttons "Get me out of here" and "Add exception", which appear on warning page for bad security certificate, are missing in serbian localization.

Reproducible: Always

Steps to Reproduce:
1. Install serbian localization.
2. Open provided URL.
3. Notice the missing buttons.
Actual Results:  
The buttons are missing.

Expected Results:  
The buttons should be visible.

I am using the Ubuntu package, but I am pretty sure the localizations were imported intact.

Comment 1

[Saša Bodiroža]

Attachment: Diff of locale/browser/netError.diff

The attached diff fixes the problem in Serbian localization. To apply it, unpack chrome/sr.jar, and apply the diff to the locale/ directory. Then zip it back.

Comment 2

[Filip Miletic]

Attachment: Solution for the Serbian localization package.

This is a glitch in the translate toolkit 1.1.1 that I use.  I will also forward this to the TT authors.

Comment 3

[Filip Miletic]

FWIW, I tested the patch in Comment #2 with 3.0rc2 and it works.  That is, the buttons are now shown (and translated at that).

Comment 4

[Saša Bodiroža]

Cool. I'm glad that's fixed.

Comment 5

[Filip Miletic]

Any chance for a review?

Comment 6

[Saša Bodiroža]

Should I set the review flag, or was the comment #5 intended for somebody else?

Comment 7

[Filip Miletic]

You did your stuff.  The comment #5 is for [e-mail] (Axel).

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 324650 [details] [diff] [review]
Solution for the Serbian localization package.

a=me, please land this with a check-in comment referencing this bug and my approval.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Comment 10

[Saša Bodiroža]

Hello,

I think that this bug has reappeared in Firefox 3.0.1.

Comment 11

[Filip Miletic]

Should be fixed for 3.1.