Closed Bug 438653 Opened 16 years ago Closed 16 years ago

Move browser tests to xpcshell tests

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1a1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file, 2 obsolete files)

v1.1
12.50 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
From bug 437342 comment 1 and 2.
Attached patch v0.1 (obsolete) — — Splinter Review 
This doesn't quite work - I'm triggering a lovely assertion:
http://mxr.mozilla.org/mozilla-central/source/dom/src/jsurl/nsJSProtocolHandler.cpp#140

Attempting to figure out how to get around that.
Looks like the one test is going to have to be a chrome test after all :(
Attached patch v1.0 (obsolete) — — Splinter Review 

        Attachment #324659 -
        Attachment is obsolete: true

        Attachment #324818 -
        Flags: review?(gavin.sharp)

    
  
Whiteboard: [has patch][needs review gavin]

        Attachment #324818 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/998cc827bfb1
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review gavin]
Target Milestone: --- → Firefox 3.1

    
    

    
  
Backed out because the tests founds leaks, which causes orange...
http://hg.mozilla.org/mozilla-central/index.cgi/rev/fa1f79ae3610
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.1
        — 
          — Splinter Review
      

    


  
Fixed the leak

        Attachment #324818 -
        Attachment is obsolete: true

        Attachment #326940 -
        Flags: review?(gavin.sharp)

    
  
Whiteboard: [has patch][needs review gavin]
Target Milestone: Firefox 3.1 → Firefox 3.1a1

    
    

    
  
Comment on attachment 326940 [details] [diff] [review]
v1.1

>diff --git a/toolkit/mozapps/downloads/tests/browser/browser_bug_412360.js b/toolkit/mozapps/downloads/tests/chrome/test_bug_412360.xul

>+    // Unregister the factory so we do not leak
>+    Components.manager.QueryInterface(Ci.nsIComponentRegistrar).
>+    unregisterFactory(

Pretty weird indentation style, looks like an unrelated function call!

        Attachment #326940 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
(In reply to comment #7)
> (From update of attachment 326940 [details] [diff] [review])
> >diff --git a/toolkit/mozapps/downloads/tests/browser/browser_bug_412360.js b/toolkit/mozapps/downloads/tests/chrome/test_bug_412360.xul
> 
> >+    // Unregister the factory so we do not leak
> >+    Components.manager.QueryInterface(Ci.nsIComponentRegistrar).
> >+    unregisterFactory(
> 
> Pretty weird indentation style, looks like an unrelated function call!
Yeah - just keeping with the style of the file.  Edward does some weird stuff sometimes :)

I'm going to leave it as is, but if you object, please file a bug so we can fix it in all instances in the DM test code.
Whiteboard: [has patch][needs review gavin] → [has patch][has review][can land]

    
    

    
  
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/8a2a07705bb0
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: