438718 - setItemIndex on a Livemark causes Livemark to fail to load

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Todd Agulnick]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

If a Livemark is created (via nsILivemarkService.createLivemark) and then immediately repositioned (via nsINavBookmarksService.setItemIndex), the Livemark does not load -- it persists with its "failed to load" message until Firefox is restarted.

This is reproducible using Foxmarks as follows:

1. On computer A, create a Livemark in a non-empty folder.
2. Move the Livemark from its newly created position as the last item in its parent to somewhere in the middle of that folder.
3. Sync using Foxmarks.
4. On computer B, sync using Foxmarks.
5. Open Livemark on computer B.

Expected results:
See livemark contents.

Actual results:
See "failed to load" message.

Note that there is no problem if the Livemark is left in its original position as the last child in the folder; since Foxmarks creates new items by default at the end of the folder and then moves them into position (via setItemIndex) as necessary, it appears that setItemIndex is somehow the culprit.

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[Marco Bonardo [:mak]]

This is a wontfix since setItemIndex should be used only on all the children of a folder and only for sorting (as stated by the idl), for single items moveItem should instead be used.
setItemIndex is dangerous for database coherence and we should remove it asap.