438720 - graph scaling incorrect for various series graphs (new front end)

Status: VERIFIED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

Select to graph a Ts test and a Tp_Private Bytes.  See that the graph is all crushed into the left hand side of the graph area.

Remove the Tp_Private Bytes.  See that the graph doesn't rescale.

We need better scaling here based upon what is being graphed, it also seems to get 'stuck' in a scale once it has changed it.

Comment 1

[Ryan Doherty (:rdoherty)]

Moving to 0.5, we don't have enough resources currently to take this on.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: Fix for scaling issue

Here's the fix.

Comment 3

[alice nodelman [:alice] [:anode]]

It still does the thing where it crushes everything into a small corner when attempting to compare a large test set with a small one (like Private Bytes vs. Ts) - should we consider that part of this bug as well?

Otherwise, this does fix the getting-stuck-in-bad-scale bug.

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 337999 [details] [diff] [review]
Fix for scaling issue

Fixes the stuck-in-bad-scale issue.

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: Fix for both scaling issues

This patch has the fix for both scaling issues. Small change from the first patch.

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 338212 [details] [diff] [review]
Fix for both scaling issues

Works great, fixes both scaling issues.

Comment 7

[Ryan Doherty (:rdoherty)]

Committed, revision 3537cb6f02e8

For QA:

http://graphs-stage.mozilla.org/graph.html#type=series
1) Load any 2 different tests that have a different # of data points
2) Make sure that all data points for both graphs are loaded
3) Remove the longer graph and verify the graph is resized so the shorter graph takes up the full width of the graph area.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Before, screenshot

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: After, screenshot

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; this needs the "push-needed" keyword, right?