438744 - Folders with non uniform characters (accents, Chinese, Japanese, etc) in their names do not import over from Safari.

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Hasham]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

If a folder in Safari bookmarks has a name with non uniform characters (such as a non-English letters language), Firefox will not import it over. This appears to only be in OS-X from Safari. Created as spin off of bug 417264. 

Reproducible: Always

Steps to Reproduce:
1.Create a folder in Safari with accents or Chinese/Japanese characters.
2.Open up Firefox to import bookmarks.
3.Import bookmarks from Safari.
Actual Results:  
Bookmarked folder will not import.

Expected Results:  
Bookmarked folder will import.

Comment 1

[Kohei Yoshino]

In Japan, 40% of Mac users use Firefox. We'd like to see the fix this ASAP.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I can get to this sometime in the next 2-3 weeks ... but I'm not sure
that'll be in time for the FF 3.0.1 release.  (I'm currently bogged
down in bug 357670 -- not in the patch itself, but contriving tests
for it.)

Comment 3

[Gen Kanai [:gen]]

Steven, thanks for your feedback.

Could we have another Mac-driver look at this in hopes that we could get this in to 3.0.1?

Comment 4

[Dietrich Ayala (:dietrich)]

Likely, this needs the same treatment as bug 417264. I can fix this tomorrow... unless someone else gets to it first :)

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 6

[Dietrich Ayala (:dietrich)]

safari folders w/ intl chars in the title import successfully w/ the attached fix.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Dietrich: got any tests?
Mano: please nominate for approval1.9.0.1 after reviewing.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 326348 [details] [diff] [review]
fix

r=mano

Comment 9

[Gen Kanai [:gen]]

Do we have any automated tests for this?  If not, I can gather some folks to help test.  Please let me know.  I think we're too late for 3.0.1?

Comment 10

[Gen Kanai [:gen]]

If we can have a test build posted here, we can help test. 

Comment 11

[dynamis (Tomoya ASAI)]

(In reply to comment #10)
> If we can have a test build posted here, we can help test. 

Here is a test build including the patch built with tryserver:
https://build.mozilla.org/tryserver-builds/2008-07-01_04:[e-mail]-bug438744/[e-mail]

And I can import bookmarks within Japanese name folders with this test build.

(In reply to comment #9)
> I think we're too late for 3.0.1? 

Beltzner have already changed the flag to the patch before your comment, which means we're too late for 3.0.1

Comment 12

[Dietrich Ayala (:dietrich)]

fixed in mozilla-central (46c6d7797006)

Comment 13

[dynamis (Tomoya ASAI)]

Feedback from Japanese community tester using following build:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008070402 Minefield/3.1a1pre

2843 bookmarks in 64 folders (max depth of the folders is 2) on Safari 3.1.2 was imported correctly including Japanese name folders and their children.

And I also tested with lastest minefield and could be imported some folders from Safari 3.1.1 too.

Comment 14

[dynamis (Tomoya ASAI)]

Note about importing bookmarks from 3.1.2:

I'm still using Safari 3.1.1 and not confirmed yet, but he said that Safari 3.1.2 have new special "Download" folder within the bookmark toolbar and he could not imported from the folder.
Firefox should import form the special "Download" folder too but the special folder was introduced from Safari 3.1.2 and not relating to this bug. It should be handled by different bug.

Thanks.

Comment 15

[dynamis (Tomoya ASAI)]

Sorry, please ignore comment #14. (only #14, not ignore #13)

(In reply to comment #14)
> Note about importing bookmarks from 3.1.2:
> 
> I'm still using Safari 3.1.1 and not confirmed yet, but he said that Safari
> 3.1.2 have new special "Download" folder within the bookmark toolbar and he
> could not imported from the folder.
> Firefox should import form the special "Download" folder too but the special
> folder was introduced from Safari 3.1.2 and not relating to this bug.

The special "Download" folder of the tester was hardlink folder made with AppleScript by the tester, himself. So not imported was the correct/natural behavior of Firefox.
All other folders/bookmarks of him are imported correctly and I can confirm the patch works fine.
We hope this will be included in 3.0.2 and later.

Comment 16

[Samuel Sidler (old account; do not CC)]

Comment on attachment 326348 [details] [diff] [review]
fix

Approved for 1.9.0.2. Please land in CVS. a=ss

It really would be good to get some automated tests for this though...

Comment 17

[Dietrich Ayala (:dietrich)]

fixed on branch:

Checking in browser/components/migration/src/nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v  <--  nsSafariProfileMigrator.cpp
new revision: 1.51; previous revision: 1.50
done

automating the addition of folders/bookmarks into Safari, and then an import from Safari is not trivial. it's very easy to manually test this however, so asking in-litmus.

Comment 18

[Tracy Walker [:tracy]]

verified with: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3 
and 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080930022236 Minefield/3.1b1pre