Folders with non uniform characters (accents, Chinese, Japanese, etc) in their names do not import over from Safari.

VERIFIED FIXED in Firefox 3.5

Status

()

Firefox
Migration
P1
critical
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Hasham, Assigned: dietrich)

Tracking

(4 keywords)

3.0 Branch
Firefox 3.5
PowerPC
Mac OS X
intl, jp-critical, verified1.9.0.2, verified1.9.1
Points:
---
Bug Flags:
blocking-firefox3.5 +
wanted1.9.0.x +
in-litmus ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
2.32 KB, patch
mano
: review+
Samuel Sidler (old account; do not CC)
: approval1.9.0.2+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

If a folder in Safari bookmarks has a name with non uniform characters (such as a non-English letters language), Firefox will not import it over. This appears to only be in OS-X from Safari. Created as spin off of bug 417264. 

Reproducible: Always

Steps to Reproduce:
1.Create a folder in Safari with accents or Chinese/Japanese characters.
2.Open up Firefox to import bookmarks.
3.Import bookmarks from Safari.
Actual Results:  
Bookmarked folder will not import.

Expected Results:  
Bookmarked folder will import.
Component: Bookmarks → Migration
QA Contact: bookmarks → migration
(Assignee)

Updated

9 years ago
Flags: blocking-firefox3.1?
Priority: -- → P1
Target Milestone: --- → Firefox 3.1
(Assignee)

Updated

9 years ago
Version: unspecified → 3.0 Branch

Updated

9 years ago
Keywords: intl, jp-critical
In Japan, 40% of Mac users use Firefox. We'd like to see the fix this ASAP.
Flags: wanted1.9.0.x?

Updated

9 years ago
Severity: normal → critical
I can get to this sometime in the next 2-3 weeks ... but I'm not sure
that'll be in time for the FF 3.0.1 release.  (I'm currently bogged
down in bug 357670 -- not in the patch itself, but contriving tests
for it.)

Comment 3

9 years ago
Steven, thanks for your feedback.

Could we have another Mac-driver look at this in hopes that we could get this in to 3.0.1?
(Assignee)

Comment 4

9 years ago
Likely, this needs the same treatment as bug 417264. I can fix this tomorrow... unless someone else gets to it first :)
(Assignee)

Comment 5

9 years ago
Created attachment 326348 [details] [diff] [review]
fix
Assignee: nobody → dietrich
Status: NEW → ASSIGNED
Attachment #326348 - Flags: review?(mano)
(Assignee)

Comment 6

9 years ago
safari folders w/ intl chars in the title import successfully w/ the attached fix.
Dietrich: got any tests?
Mano: please nominate for approval1.9.0.1 after reviewing.
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1+
Comment on attachment 326348 [details] [diff] [review]
fix

r=mano
Attachment #326348 - Flags: review?(mano)
Attachment #326348 - Flags: review+
Attachment #326348 - Flags: approval1.9.0.1?
Attachment #326348 - Flags: approval1.9.0.1? → approval1.9.0.2?

Comment 9

9 years ago
Do we have any automated tests for this?  If not, I can gather some folks to help test.  Please let me know.  I think we're too late for 3.0.1?

Comment 10

9 years ago
If we can have a test build posted here, we can help test. 
(In reply to comment #10)
> If we can have a test build posted here, we can help test. 

Here is a test build including the patch built with tryserver:
https://build.mozilla.org/tryserver-builds/2008-07-01_04:56-dynamis@mozilla-japan.org-bug438744/dynamis@mozilla-japan.org-bug438744-firefox-try-mac.dmg

And I can import bookmarks within Japanese name folders with this test build.

(In reply to comment #9)
> I think we're too late for 3.0.1? 

Beltzner have already changed the flag to the patch before your comment, which means we're too late for 3.0.1
(Assignee)

Comment 12

9 years ago
fixed in mozilla-central (46c6d7797006)
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Feedback from Japanese community tester using following build:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008070402 Minefield/3.1a1pre

2843 bookmarks in 64 folders (max depth of the folders is 2) on Safari 3.1.2 was imported correctly including Japanese name folders and their children.

And I also tested with lastest minefield and could be imported some folders from Safari 3.1.1 too.
Note about importing bookmarks from 3.1.2:

I'm still using Safari 3.1.1 and not confirmed yet, but he said that Safari 3.1.2 have new special "Download" folder within the bookmark toolbar and he could not imported from the folder.
Firefox should import form the special "Download" folder too but the special folder was introduced from Safari 3.1.2 and not relating to this bug. It should be handled by different bug.

Thanks.
Sorry, please ignore comment #14. (only #14, not ignore #13)

(In reply to comment #14)
> Note about importing bookmarks from 3.1.2:
> 
> I'm still using Safari 3.1.1 and not confirmed yet, but he said that Safari
> 3.1.2 have new special "Download" folder within the bookmark toolbar and he
> could not imported from the folder.
> Firefox should import form the special "Download" folder too but the special
> folder was introduced from Safari 3.1.2 and not relating to this bug.

The special "Download" folder of the tester was hardlink folder made with AppleScript by the tester, himself. So not imported was the correct/natural behavior of Firefox.
All other folders/bookmarks of him are imported correctly and I can confirm the patch works fine.
We hope this will be included in 3.0.2 and later.
Comment on attachment 326348 [details] [diff] [review]
fix

Approved for 1.9.0.2. Please land in CVS. a=ss

It really would be good to get some automated tests for this though...
Attachment #326348 - Flags: approval1.9.0.2? → approval1.9.0.2+
(Assignee)

Comment 17

9 years ago
fixed on branch:

Checking in browser/components/migration/src/nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v  <--  nsSafariProfileMigrator.cpp
new revision: 1.51; previous revision: 1.50
done

automating the addition of folders/bookmarks into Safari, and then an import from Safari is not trivial. it's very easy to manually test this however, so asking in-litmus.
Flags: in-litmus?
Keywords: fixed1.9.0.2
verified with: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3 
and 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080930022236 Minefield/3.1b1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.0.2 → verified1.9.0.2
Keywords: fixed1.9.1

Updated

8 years ago
Keywords: verified1.9.1
Keywords: fixed1.9.1
Target Milestone: Firefox 3.1 → Firefox 3.5
You need to log in before you can comment on or make changes to this bug.