438753 - link to non-series graph with selection doesn't highlight selection (new front end)

Status: VERIFIED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

The link provided should display a graph with a selection highlighted.  While the highlighted section appears in the upper, smaller graph the lower, large graph still displays all the available data.  The lower, larger graph should be limited to only the data in the selected range.

Comment 1

[Michael Morgan [:morgamic]]

Moving to 0.4 since 0.3 is the 'get stable' milestone.

Comment 2

[Les Orchard [:lorchard]]

Attachment: Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

The attached patch appears to fix the issue.  Adding rdoherty and anodelman to review, for good measure.

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 335100 [details] [diff] [review]
Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

Works!

Comment 4

[Les Orchard [:lorchard]]

Pushed changeset 104:060665e0ea22

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

http://graphs.mozilla.org/g2/graph.html#show=61148&sel=1211854839,1212888699 is a 404; can someone point me to a working link on production against which I can compare a staging link, to verify the fix?  Thanks!

Comment 6

[Les Orchard [:lorchard]]

Something like this should work:

http://graphs-stage.mozilla.org/graph.html#show=133&sel=1181218130,1182420833

Also, to reproduce from scratch:

1) Go to http://graphs-stage.mozilla.org/graph.html
2) Add a graph.
3) Select a part of the graph in the overview up top.
4) Open the "link to this graph" link toward the bottom in a new tab.
5) That new tab should show the highlighted section zoomed in just like the original tab.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

OK; thanks.  Yeah, it's the new-tab behavior that doesn't work in production, and which does on staging.

Verified FIXED

Comment 8

[alice nodelman [:alice] [:anode]]

Comment on attachment 335100 [details] [diff] [review]
Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

I'm late to this party, but might as well offer my belated r+.