link to non-series graph with selection doesn't highlight selection (new front end)

VERIFIED FIXED in 0.4

Status

Webtools Graveyard
Graph Server
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: alice, Assigned: lorchard)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
The link provided should display a graph with a selection highlighted.  While the highlighted section appears in the upper, smaller graph the lower, large graph still displays all the available data.  The lower, larger graph should be limited to only the data in the selected range.
(Reporter)

Updated

10 years ago
Summary: link to selection doesn't work (new front end) → link to non-series graph with selection doesn't highlight selection (new front end)
Assignee: nobody → lorchard
Target Milestone: --- → 0.3
Moving to 0.4 since 0.3 is the 'get stable' milestone.
Target Milestone: 0.3 → 0.4
(Assignee)

Comment 2

10 years ago
Created attachment 335100 [details] [diff] [review]
Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

The attached patch appears to fix the issue.  Adding rdoherty and anodelman to review, for good measure.
Attachment #335100 - Flags: review?(rdoherty)
Attachment #335100 - Flags: review?(anodelman)
Comment on attachment 335100 [details] [diff] [review]
Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

Works!
Attachment #335100 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 4

10 years ago
Pushed changeset 104:060665e0ea22
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
http://graphs.mozilla.org/g2/graph.html#show=61148&sel=1211854839,1212888699 is a 404; can someone point me to a working link on production against which I can compare a staging link, to verify the fix?  Thanks!
(Assignee)

Comment 6

10 years ago
Something like this should work:

http://graphs-stage.mozilla.org/graph.html#show=133&sel=1181218130,1182420833

Also, to reproduce from scratch:

1) Go to http://graphs-stage.mozilla.org/graph.html
2) Add a graph.
3) Select a part of the graph in the overview up top.
4) Open the "link to this graph" link toward the bottom in a new tab.
5) That new tab should show the highlighted section zoomed in just like the original tab.
OK; thanks.  Yeah, it's the new-tab behavior that doesn't work in production, and which does on staging.

Verified FIXED
Status: RESOLVED → VERIFIED
(Reporter)

Comment 8

10 years ago
Comment on attachment 335100 [details] [diff] [review]
Patch to perform time range update on big graph when a test is added with a selection highlight set on the small graph.

I'm late to this party, but might as well offer my belated r+.
Attachment #335100 - Flags: review?(anodelman) → review+
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.