438765 - ESC closes the download manager instead of clearing a search

Status: NEW

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

This happens if you have focus out of the search box.

1) Do a search with at least one result
2) <tab> to place focus on the first download
3) press <esc>

Result: download window closes

Expected:  search is cleared

Comment 1

[Simon Bünzli]

This is so far the only search box I've encountered where Esc clears the search term (main search bar, history/bookmarks sidebar, Library, Cookies/etc. exceptions). For consistency, I'd rather have Esc always close the DM.

BTW: Is it just me or does Esc indeed remove the focus from the DM's search bar, making the shortcut kinda useless for directly restarting a new search?

Comment 2

[Shawn Wilsher :sdwilsh]

escape twice does in fact clear the location bar - the first time will close the popup.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As Simon has already pointed out, that would be the only place where a filtered list gets resetted. Alex, what do you think?

Comment 4

[Ed Lee :Mardak]

Add-ons search? All-tabs search?

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

We should match the add-ons manager for internal consistency (or make it match the download manager).  I think mapping esc to closing certain windows is more of a Windows thing (not entirely sure), but I guess we have to consider people using Firefox on multiple platforms and expecting the same keyboard shortcut functionality.

Anyone know the full list of windows we close with esc, or which operating systems use esc in this way?

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> We should match the add-ons manager for internal consistency (or make it match
> the download manager).

They do match currently, at least on Windows.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> Anyone know the full list of windows we close with esc, or which operating
> systems use esc in this way?

At least on OS X its really inconsistent at the moment. Here a raw list of windows:

Cmd+W
-----
* Options: Exception windows for pop-ups, images, cookies, add-ons, offline data
* Options: Show cookies
* Options: Saved passwords
* Library

ESC
---
* Options: All windows under "Advanced | Encryption"
* Clear recent history

Both
----
* About window
* Options
* Options: Exception for passwords (with a beep by Cmd+W)
* Download Manager
* Add-ons Manager
* Error Console
* Page Info
* Update window