438767 - An Advanced, direct-match search for "Google Site Indexer" doesn't return it as the first result

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

URL: https://preview.addons.mozilla.org/en-US/firefox/search?q=%22google+site+indexer%22&cat=all&as=true&appid=1&lver=0.3&hver=3.1a1pre&atype=1&pid=1&lup=&pp=20&sort=name

Steps to Reproduce:

1. Load the above URL, which is merely "Google Site Indexer" (quotes don't matter), with:
A) Application - "Firefox"
B) Version - 0.3 -> 3.1a1pre
C) Type - Extension

as parameters.

Actual Results:

A ton of results are returned, with "Google Site Indexer" among them; it is, however, alphabetized and so appears a few pages in (depending on your "per page" setting).

Expected Results:

I think it should be returned as the first result -- just like it is with "flat" search

Flat search returns this as the first hit.

Comment 1

[Chris Pollett]

what sort order did you choose stephend? advanced search defaults to alphabetical order.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah: I defaulted to alphabetical -- shouldn't we return exact matches up front if we have them, in Advanced search?

Comment 3

[Chris Pollett]

Attachment: Patch to fix this and implement Baz's advance search suggestions

The patch fixes the google site indexer problem by adding a new sort option: Keyword Match which is made the default sort order.

In addition to fixing this bug it also implements Baz's suggestions for UI improvements:

1) Can't find Fx 3 compatible themes: 
From the irc discussion, it was desire that if one leaves the search field blank, uses advanced search and selects the type as themes, it would filter by theme. This is now implemented.

2) Can't easily find Fx 3 related add-ons 
3) Version ranges are too complex for the average user  
2 and 3 are related. Basically, I don't list every single version anymore. I list major version. minor version, say 3.0, and the search goes as 3.0*.
This thus also includes alpha and beta variants of that version. There is a new option Any. If you turn JS off you can still do the more precise search by filling in the version exactly. I also limited the versions displayed according to what Baz requested.

4) Bugs in how compat ranges work at the moment 
This wasn't really a bug. It was that 3.0a is an earlier version than 3.0 in the way things are set up with Firefox. It is now obsolete because of the fix to 2 and 3.

5) Platform ANY patch hasn't landed or tested yet
[9:27pm] morgamic: 18:36 < baz> 
This landed with optimize search patch.

6) empty search should get you add addons, 
This was requested for advanced search only. As I have implemented it. It will show if change the type away from Any. Otherwise, still returns no result.

7) Category is not factored in
The problem here was what to do if someone selects a category value and a type value. The solution: if someone selects a category value by JS the Type will be set to Any. Similarly, if someone selects a type the category is set to Any.

Comment 4

[Chris Pollett]

Attachment: this patch implements some further tweaks from irc discussion

Comment 5

[Chris Pollett]

Attachment: patch with version ranges bug fixed

Comment 6

[Chris Pollett]

Attachment: patch with full text search using boolean mode

Comment 7

[Michael Morgan [:morgamic]]

Comment on attachment 324928 [details] [diff] [review]
patch with full text search using boolean mode

Nice work, Chris - I think this looks solid, can't find a reason not to ship.

Comment 8

[Chris Pollett]

checked into r15437

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I filed 439027 to cover the pre-populating of the "Version X to Any" ranges with the appropriate browser-derived version.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://preview.addons.mozilla.org/en-US/firefox/search?q=google+site+indexer&cat=all&as=true&vfuz=true&appid=1&lver=1.0&hver=any&atype=1&pid=1&lup=&pp=20&sort=, which is essentially the same search criteria in comment 0, adjusted for our new ranges.