438782 - Links should not unconditionally receive an accessible action of "jump"

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008061105 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008061105 Minefield/3.0pre

Gecko unconditionally exposes link objects with an accessible action of "jump". This is incorrect for links which have no href target (anchors) and no onClick handler, as they perform no action. Where there is an href or an onClick, the action should be "jump" or "click", but where there is neither, there should be no action.

Reproducible: Always

Steps to Reproduce:
1. Open the attached test case.
2. Examine the accessible action for the three link objects.
Actual Results:  
The action is "jump" for all link objects.

Expected Results:  
The action for each link object should be as follows:
* link object with href: "jump"
* link object with no href or onClick: none
* link object with onClick: "click"

Comment 1

[James Teh [:Jamie]]

Attachment: Test case.

This sample presents three types of link objects. The actual and expected actions are described above.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch (cvs)

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 324923 [details] [diff] [review]
patch (cvs)

1. Please test that the ARIA link also exposes an useful action.
2. Please test the "jump" action on the other links like the normal hyperlink etc., too, so the test catches any possible regressions.

With that fixed, r=me.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #3)

> 2. Please test the "jump" action on the other links like the normal hyperlink
> etc., too, so the test catches any possible regressions.

could you point some examples, that's something different from the <a href=""/>, right?

Comment 5

[Marco Zehe (:MarcoZ)]

Yes, I just want to make sure we test them all in case something changes that may break any of these.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch2

changed a bit version of previous patch, rerequest review

Comment 7

[Marco Zehe (:MarcoZ)]

Comment on attachment 325697 [details] [diff] [review]
patch2

r=me, thanks!

Comment 8

[alexander :surkov (:asurkov)]

checked in on mozilla-central

Comment 9

[James Teh [:Jamie]]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008062103 Minefield/3.1a1pre.