438961 - "x of 5" numbers overlap each other when advancing forward/back

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

The "x of 5" numbers overlap when you go back/forward, on the various Tips & Tricks pages, such as:

https://be.www-trunk.stage.mozilla.com/be/firefox/tips/

Hopefully the screenshot makes it clear; seem to affect non en-US locales.

Comment 1

[Pascal Chevrel:pascalc]

consequence of bug #438899, it worked before the js library change.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> consequence of bug #438899, it worked before the js library change.
> 

Do you have evidence of that?  Adding utilities.js doesn't change it for me.

Comment 3

[Pascal Chevrel:pascalc]

I worked weeks on this page and until a few days ago it was working correctly, furthermore we use the old version of the js code for tips pages on mozilla europe and we don't have this bug.

Comment 4

[Wil Clouser [:clouserw]]

Removing mozilla-pager fixes this for me and doesn't appear to break the animation.  sgarrity - why do we need mozilla-pager?

Comment 5

[Steven Garrity [:sgarrity]]

(In reply to comment #4)
> Removing mozilla-pager fixes this for me and doesn't appear to break the
> animation.  sgarrity - why do we need mozilla-pager?

I think we're including mozilla-pager.js twice on these pages - it's being added in the footer and in the header. It should only be done in the header.

Comment 6

[Steven Garrity [:sgarrity]]

Removed extra mozilla-pager.js include from footer of all locales in r15453.

Comment 7

[Steven Garrity [:sgarrity]]

r15453 seems to have done it.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED