Closed Bug 438997 Opened 12 years ago Closed 12 years ago

DoApplyRenderingChangeToTree should not invalidate SVG frames

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
DoApplyRenderingChangeToTree calls aFrame->Invalidate(aFrame->GetOverflowRect()) for all kinds of frames including SVG frames. This is incorrect for SVG frames since their mRects are not meaningful in this context (they're used to store device-pixel bounds). We should just ignore SVG frames since they do their own invalidation on style context changes.

I don't have a test, I just noticed this was causing unnecessary and unwanted invalidation.
Attachment #324909 - Flags: superreview?(dbaron)
Attachment #324909 - Flags: review?(dbaron)
Comment on attachment 324909 [details] [diff] [review]
fix

r+sr=dbaron
Attachment #324909 - Flags: superreview?(dbaron)
Attachment #324909 - Flags: superreview+
Attachment #324909 - Flags: review?(dbaron)
Attachment #324909 - Flags: review+
Checked in
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.