Closed
Bug 438999
Opened 17 years ago
Closed 17 years ago
nsHTMLDocument::UpdateIdTableEntry should not return an error just because the ID table is not live
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INVALID
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 obsolete file)
It does NS_ENSURE_TRUE(entry, NS_ERROR_OUT_OF_MEMORY); when the entry may be null just because the ID table is not live and the ID is not being tracked. In that case we should return NS_OK. I couldn't come up with a testcase where this causes a problem but it is worrying.
Attachment #324910 -
Flags: superreview?(jonas)
Attachment #324910 -
Flags: review?(jonas)
Comment on attachment 324910 [details] [diff] [review]
fix
I think it'll only return null for out-of-memory. If there is no entry it'll return a non-null-but-not-busy entry.
|
Assignee | |
Comment 3•17 years ago
|
||
I guess you're right!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•17 years ago
|
Attachment #324910 -
Attachment is obsolete: true
Attachment #324910 -
Flags: superreview?(jonas)
Attachment #324910 -
Flags: review?(jonas)
You need to log in
before you can comment on or make changes to this bug.
Description
•