Created attachment 324910 [details] [diff] [review] fix It does NS_ENSURE_TRUE(entry, NS_ERROR_OUT_OF_MEMORY); when the entry may be null just because the ID table is not live and the ID is not being tracked. In that case we should return NS_OK. I couldn't come up with a testcase where this causes a problem but it is worrying.
Comment on attachment 324910 [details] [diff] [review] fix I think it'll only return null for out-of-memory. If there is no entry it'll return a non-null-but-not-busy entry.
I guess you're right!
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
11 years ago
You need to log in before you can comment on or make changes to this bug.