Empty list when searching for search engines

VERIFIED FIXED

Status

VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: baz, Assigned: cpollett)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Type=Search Engine, Version=Any-Any generates a URL like: https://preview.addons.mozilla.org/en-US/firefox/search?q=&cat=all&as=true&appid=1&lver=any&hver=any&atype=4&pid=1&lup=&pp=20&sort=

with zero results - that doesn't seem right. Perhaps we are checking if the particular search engine plugin has version info -- it doesn't.

Expected results: see all the search engines
(Assignee)

Comment 1

10 years ago
Created attachment 325032 [details] [diff] [review]
patch for this and 439112

this only happened for advance search of search engines. It was caused because we where checking for compatible applications which we shouldn't do for search engines. Added OR clause to sql much like the stuff that had earlier been done with $_app_compat. This patch also fixes 439112. I now do boolean math of form
term1* term2*, etc rather than +term1* +term2* . The latter forces that the term exists. Better GMail now shows up on the 2 or 3 third page of results.
Assignee: nobody → cpollett
Status: NEW → ASSIGNED
Attachment #325032 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #325032 - Flags: review? → review?(clouserw)
The patch works, but it makes search engines show up in type=any lists too.  I think we need more differentiation between extensions and search engines before this happens because it's not obvious what it is or what it does (the descriptions for the search engines pretty much don't exist).
(Assignee)

Comment 3

10 years ago
So you want the same sort of patch, but search engines not showing up for type any?
(In reply to comment #3)
> So you want the same sort of patch, but search engines not showing up for type
> any?
> 

I'm fishing for input.  In my opinion search engines should show up in results, but currently they don't look good.  We could either flag them as search engines on the results page somehow or as a quick fix we could edit all their descriptions to say something about being search engines.

Or maybe I'm the only one that thinks this way and we should just do your patch. :)  Anyone else have opinions?
(Reporter)

Comment 5

10 years ago
Based on URLs from cpollett's preview box, it doesn't looks so bad. So, let's go with Chris' patch for now and we can improve the search engine display results in a different but. (Even looking a mixed results that include search engine + extension types doesn't look that bad). So, we are fine.

Updated

10 years ago
Attachment #325032 - Flags: review?(clouserw) → review+
(Assignee)

Comment 6

10 years ago
checked into r16110
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.