Closed
Bug 439040
Opened 17 years ago
Closed 17 years ago
Page redirects for start page don't work properly
Categories
(support.mozilla.org :: General, defect)
support.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
FIXED
0.6
People
(Reporter: djst, Assigned: laura)
References
()
Details
(Whiteboard: sumo_only)
Attachments
(1 file)
1.02 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
When visiting http://support.mozilla.com/ as a logged out user, you get different (and inconsistent) results depending on the lang string.
intl.accept_languages -> page it redirects to
---------------------------------------------
"en-us" -> http://support.mozilla.com/en-US/kb/Firefox+Support+Home+Page
All content shown in English
"de,en-us" -> http://support.mozilla.com/en-US/kb/Firefox+Support+Home+Page
All content shown in English
"de" -> http://support.mozilla.com/
All content shown in German (but as you can see above, no URL redirect is made)
"sv" || "sv-se" || "sv-se,se" -> http://support.mozilla.com/
Main page content shown in English, but UI (e.g. search box text) shown in Swedish.
Note that both the German and Swedish start pages are published and fully translated, but the content shown is different.
Also, is the URL http://support.mozilla.com/ not cached? Because if I change intl.accept_languages from "de" to "sv" and reload, I get different content right away.
Reporter | ||
Updated•17 years ago
|
Summary: Page redirects for start page doesn't work properly → Page redirects for start page don't work properly
Assignee | ||
Comment 1•17 years ago
|
||
Locales that don't redirect correctly and go direct to support.mozilla.com aren't hitting the NS for the homepage.
Severity: normal → critical
Assignee | ||
Updated•17 years ago
|
Severity: critical → major
Reporter | ||
Comment 2•17 years ago
|
||
If "en-us" is included in the string, it will always direct properly, but some locales actually don't have that in their language string. Examples:
"mk,en" -> http://support.mozilla.com/ (no cache)
"pl,en-us,en" -> http://support.mozilla.com/en-US/kb/Firefox+Support+Home+Page (cached, but should really be http://support.mozilla.com/pl/kb/Firefox+Support+Home+Page)
Comment 3•17 years ago
|
||
This is a patch that fixes the problem, but I'm not sure if it is the most efficient way of doing it.
Note that index.php is being called now. Traditionally in tiki, index.php redirects to tiki-index.php, but we changed earlier that to reduce one redirect for performance reasons.
Attachment #325419 -
Flags: review?(laura)
Assignee | ||
Updated•17 years ago
|
Attachment #325419 -
Flags: review?(laura) → review+
Comment 6•17 years ago
|
||
in r16530 in trunk but somehow not working on support-stage yet. Works on my development env.
Keywords: push-needed
Comment 7•17 years ago
|
||
support-stage is no longer syncing to trunk apparently- need to tag or something - see bug 442353...
Comment 8•17 years ago
|
||
committed to r16591 in production.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Keywords: push-needed
Reporter | ||
Updated•16 years ago
|
Whiteboard: sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•