439075 - Importing bugs which have a multi-select field with a single value fail

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Frédéric Buclin]

I tried to import a bug from a 2.23.3 installation into a 3.1.4 one. Bugs which have no dependency or several ones are imported without any problem. Those having a single dependency cannot be imported and the following error is thrown:

Can't use string ("1020") as an ARRAY ref while "strict refs" in use at ./importxml.pl line 568, <> chunk 1.


The problem comes from:

    if ( defined $bug_fields{'dependson'} ) {
        $comments .= "This bug depended on bug(s) " .
                     join(' ', @{$bug_fields{'dependson'}}) . ".\n";

If there is a single <dependson>1020</dependson> in the XML file, it's not seen as an array and @{...} fails.

I cannot reproduce the problem when importing into Bugzilla 3.0.4, so this regression is pretty new. We should fix it before releasing 3.2 RC1.

Comment 1

[Frédéric Buclin]

OK, I regressed it in bug 417030, so I will fix it myself.

Comment 2

[Frédéric Buclin]

As discussed with ghendricks on IRC, this affects any multi-select field which has only one value selected, including custom multi-select fields, the dependency fields (dependson and blocked) and the CC list. In all other cases, this should be fine.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Make sure all checks about multi-select fields always have an array in hands.

Comment 4

[Greg Hendricks]

Comment on attachment 325030 [details] [diff] [review]
patch, v1

I like it. Simple, easy to remember.

Comment 5

[Frédéric Buclin]

tip:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.84; previous revision: 1.83
done

3.1.4:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.82.2.2; previous revision: 1.82.2.1
done