439133 - "Show Image" is poorly labeled, can be confused with "View Image"

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Dão Gottwald [:dao]]

The difference between "show" and "view" seems extremely subtle, if there's a significant difference at all. I guess the words could actually be swapped and nobody would care. I think we should either call the former "reload" or have only "view" and make it behave like "reload" if an image isn't successfully loaded.

The current strings are even worse in localized builds where "show" and "view" translate to the same word literally. Random examples:

de-DE
234 <!ENTITY showImageCmd.label           "Grafik anzeigen">
235 <!ENTITY showImageCmd.accesskey       "G">
236 <!ENTITY viewImageCmd.label           "Grafik anzeigen">
237 <!ENTITY viewImageCmd.accesskey       "i">

ga-IE:
234 <!ENTITY showImageCmd.label "Taispeáin Íomhá">
235 <!ENTITY showImageCmd.accesskey "T">
236 <!ENTITY viewImageCmd.label "Taispeáin Íomhá">
237 <!ENTITY viewImageCmd.accesskey "T">

The French team was smart enough to take "show" as "load":

234 <!ENTITY showImageCmd.label           "Charger l'image">
235 <!ENTITY showImageCmd.accesskey       "m">
236 <!ENTITY viewImageCmd.label           "Afficher l'image">
237 <!ENTITY viewImageCmd.accesskey       "h">

Comment 1

[Cédric Corazza]

(In reply to comment #1)
> The French team was smart enough to take "show" as "load":
> 234 <!ENTITY showImageCmd.label           "Charger l'image">
> 235 <!ENTITY showImageCmd.accesskey       "m">
> 236 <!ENTITY viewImageCmd.label           "Afficher l'image">
> 237 <!ENTITY viewImageCmd.accesskey       "h">
Thanks :)
In fact this can only be noticed when an image is blocked and one makes a right click on it. That's the way we found this "oddity". Maybe this can be added in l10n litmus tests?
My two cents

Comment 2

[Simon Montagu :smontagu]

I filed separate bugs for the affected localizations.

Comment 3

[Dão Gottwald [:dao]]

Attachment: "Show Image" -> "Reload Image"

SeaMonkey already calls it "Reload Image", btw.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Created an attachment (id=325787) [details]
> "Show Image" -> "Reload Image"
> 
> SeaMonkey already calls it "Reload Image", btw.

But note that SeaMonkey shows the menu item for all loaded images, we only show it for partially loaded images.

Comment 5

[Egor Pelevin]

An alternative solution would be to fix bug 417545 and to drop "View image" entirely

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 325787 [details] [diff] [review]
"Show Image" -> "Reload Image"

Dao asked me to give this a quick review.  I think the term "Reload" matches the behavior and our existing terminology better than the previous term "Show."  Beltzner: if you disagree by all means change the ui-review, (and sorry for jumping in and taking the review).

Comment 7

[Dão Gottwald [:dao]]

Attachment: updated to trunk

Comment 8

[Asaf Romano (gone)]

Comment on attachment 344856 [details] [diff] [review]
updated to trunk

r=mano

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/1a9b8db616f3

Comment 10

[Justin Dolske [:Dolske]]

If one was inclined to add tests for this, browser/base/content/test/test_contextmenu.html provides most of the framework for doing so. (You'd probably have to add a bit to make some element display this context menu.)

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Shiretoko/3.5b4pre ID:20090331041754

and on trunk build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331044608