Closed Bug 439133 Opened 11 years ago Closed 11 years ago

"Show Image" is poorly labeled, can be confused with "View Image"

Categories

(Firefox :: Menus, defect)

3.0 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: ue, verified1.9.1)

Attachments

(1 file, 1 obsolete file)

The difference between "show" and "view" seems extremely subtle, if there's a significant difference at all. I guess the words could actually be swapped and nobody would care. I think we should either call the former "reload" or have only "view" and make it behave like "reload" if an image isn't successfully loaded.

The current strings are even worse in localized builds where "show" and "view" translate to the same word literally. Random examples:

de-DE
234 <!ENTITY showImageCmd.label           "Grafik anzeigen">
235 <!ENTITY showImageCmd.accesskey       "G">
236 <!ENTITY viewImageCmd.label           "Grafik anzeigen">
237 <!ENTITY viewImageCmd.accesskey       "i">

ga-IE:
234 <!ENTITY showImageCmd.label "Taispeáin Íomhá">
235 <!ENTITY showImageCmd.accesskey "T">
236 <!ENTITY viewImageCmd.label "Taispeáin Íomhá">
237 <!ENTITY viewImageCmd.accesskey "T">

The French team was smart enough to take "show" as "load":

234 <!ENTITY showImageCmd.label           "Charger l'image">
235 <!ENTITY showImageCmd.accesskey       "m">
236 <!ENTITY viewImageCmd.label           "Afficher l'image">
237 <!ENTITY viewImageCmd.accesskey       "h">
Flags: blocking-firefox3.1?
Version: Trunk → 3.0 Branch
(In reply to comment #1)
> The French team was smart enough to take "show" as "load":
> 234 <!ENTITY showImageCmd.label           "Charger l'image">
> 235 <!ENTITY showImageCmd.accesskey       "m">
> 236 <!ENTITY viewImageCmd.label           "Afficher l'image">
> 237 <!ENTITY viewImageCmd.accesskey       "h">
Thanks :)
In fact this can only be noticed when an image is blocked and one makes a right click on it. That's the way we found this "oddity". Maybe this can be added in l10n litmus tests?
My two cents

I filed separate bugs for the affected localizations.
Depends on: 436834
No longer depends on: 439396
Keywords: uiwanted
Attached patch "Show Image" -> "Reload Image" (obsolete) — Splinter Review
SeaMonkey already calls it "Reload Image", btw.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #325787 - Flags: ui-review?(beltzner)
(In reply to comment #3)
> Created an attachment (id=325787) [details]
> "Show Image" -> "Reload Image"
> 
> SeaMonkey already calls it "Reload Image", btw.

But note that SeaMonkey shows the menu item for all loaded images, we only show it for partially loaded images.
An alternative solution would be to fix bug 417545 and to drop "View image" entirely
Comment on attachment 325787 [details] [diff] [review]
"Show Image" -> "Reload Image"

Dao asked me to give this a quick review.  I think the term "Reload" matches the behavior and our existing terminology better than the previous term "Show."  Beltzner: if you disagree by all means change the ui-review, (and sorry for jumping in and taking the review).
Attachment #325787 - Flags: ui-review?(beltzner) → ui-review+
Attached patch updated to trunkSplinter Review
Attachment #325787 - Attachment is obsolete: true
Attachment #344856 - Flags: review?(mano)
Keywords: uiwanted
Comment on attachment 344856 [details] [diff] [review]
updated to trunk

r=mano
Attachment #344856 - Flags: review?(mano) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/1a9b8db616f3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
If one was inclined to add tests for this, browser/base/content/test/test_contextmenu.html provides most of the framework for doing so. (You'd probably have to add a bit to make some element display this context menu.)
Flags: blocking-firefox3.1? → blocking-firefox3.1+
verified FIXED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Shiretoko/3.5b4pre ID:20090331041754

and on trunk build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331044608
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.