Closed Bug 439172 Opened 12 years ago Closed 12 years ago

create build flags for hildon and osso

Categories

(Firefox for Android Graveyard :: General, defect)

Other
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: blassey, Assigned: blassey)

References

Details

(Keywords: mobile)

Attachments

(1 file, 2 obsolete files)

in some sections of code we're doing things that are hildon or osso specific, the build system should provide flags for separating that out.
Attachment #325056 - Flags: review?(ted.mielczarek)
Comment on attachment 325056 [details] [diff] [review]
looks for MAEMO=1 in mozconfig to add NS_HILDON and NS_OSSO defines

+NS_HILDON	= @NS_HILDON@
+NS_OSSO		= @NS_HILDON@


This seems wrong. Shouldn't it be:

+NS_HILDON	= @NS_HILDON@
+NS_OSSO	= @NS_OSSO@
Attached patch fixed NS_OSSO assignment (obsolete) — Splinter Review
Assignee: nobody → blassey
Attachment #325056 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #325215 - Flags: review?(ted.mielczarek)
Attachment #325056 - Flags: review?(ted.mielczarek)
as I understand it, hildon is a set of mobile specific extensions to gtk and osso is nokia's shell environment and associated applications.
Blocks: 437948
Comment on attachment 325215 [details] [diff] [review]
fixed NS_OSSO assignment 

I'm fine with the names of the build flags, but I'm not keen on having it triggered by an environment variable instead of a configure flag. Any reason you chose this path? Also, is there any chance we could auto-detect any of this, or do Maemo builds just look like gtk arm builds?
Attachment #325215 - Flags: review?(ted.mielczarek) → review-
any update here?  Ted / Brad, can you wipe something up?
whip!
I'm actually checking for libhildonmime because of some weirdness when checking for libhildon 

[sbox-CHINOOK-ARMEL-2007: ~/mozilla-central] > pkg-config libhildon --version
0.21
[sbox-CHINOOK-ARMEL-2007: ~/mozilla-central] > pkg-config libhildon --cflags
Package libhildon was not found in the pkg-config search path.
Perhaps you should add the directory containing `libhildon.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libhildon' found
[sbox-CHINOOK-ARMEL-2007: ~/mozilla-central] > pkg-config libhildonmime --version
0.21
[sbox-CHINOOK-ARMEL-2007: ~/mozilla-central] > pkg-config libhildonmime --cflags
-pthread -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/dbus-1.0 -I/usr/include/gconf/2 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
Attachment #325215 - Attachment is obsolete: true
Attachment #328942 - Flags: review?(ted.mielczarek)
Comment on attachment 328942 [details] [diff] [review]
checks for libosso and libhildon with pkgconfig

wfm.
Comment on attachment 328942 [details] [diff] [review]
checks for libosso and libhildon with pkgconfig

The libhildon thing is a little goofy, but if it works for you, it's fine with me. Is that package from scratchbox or what? You might want to file a bug upstream on whoever's providing it.
Attachment #328942 - Flags: review?(ted.mielczarek) → review+
changeset:   15831:4d0715fa8f55
tag:         tip
user:        Doug Turner <dougt@meer.net>
date:        Fri Jul 11 19:28:00 2008 -0700
summary:     Bug 439172, create build flags for hildon and osso. patch=blassey, r=ted
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified via mxr
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.