Add Shiretoko as an acceptable Firefox user-agent

VERIFIED FIXED in 3.4.6

Status

addons.mozilla.org Graveyard
Public Pages
--
enhancement
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: reed, Assigned: reed)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 325073 [details] [diff] [review]
patch - v1

Shiretoko is the code-name for Firefox 3.1. AMO should support it as an acceptable alias to Firefox like GranParadiso, BonEcho, and Minefield.
Attachment #325073 - Flags: review?(fligtar)
Severity: normal → enhancement
Is this currently in use in user agents?
Build identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008061606 Minefield/3.0pre says "No."
(Assignee)

Comment 3

10 years ago
(In reply to comment #1)
> Is this currently in use in user agents?

Nope, but it will be very shortly!
Justin - feel free to change it and commit it for Reed.
(Assignee)

Comment 5

10 years ago
Just landed a patch in bug 439410, so as of the alpha1 builds starting soon, it will be. Want to get this in before freeze tonight.

(In reply to comment #4)
> Justin - feel free to change it and commit it for Reed.

Change what? Also, I have commit access, so I can commit it once reviewed.
Depends on: 439410

Updated

10 years ago
Attachment #325073 - Flags: review?(fligtar) → review+
(Assignee)

Comment 6

10 years ago
Sending        site/app/controllers/facebook_controller.php
Sending        site/app/views/elements/search.thtml
Sending        site/app/webroot/js/addons.js
Transmitting file data ...
Committed revision 17223.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.4.6
Verified FIXED; I first replaced "GranParadiso" with "Foo" via about:config (setting general.useragent.override to "string", with value, "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.0.2pre) Gecko/2008072204 Foo/3.0.2pre", saw the button text change from "Add to Firefox" to "Download Now", and then once I replaced "Foo" with "Shiretoko", the buttons were back to "Add to Firefox".
Status: RESOLVED → VERIFIED

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.