AMO theme has unnecessary scrollbar at the bottom - CSS issue

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Localization
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: tomer, Assigned: rdoherty)

Tracking

({l12y, polish, rtl})

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
When viewing the current AMO theme on RTL locale (Hebrew, as I don't see there Arabic version yet), at the bottom of the browser window there is a scrollbar (atleast on 1024x768 resolution) and some extra free space outside of the default viewport to the left. 

steps to reproduce:
Enter https://addons.mozilla.org/he/firefox

expected result: 
no scrollbar at all.
This sort of appears on ltr languages too when the window is small enough but it's not as obvious.  rdoherty is going to rock it's face. plzkthx
Assignee: nobody → rdoherty

Updated

9 years ago
Keywords: polish
I think this got worse.  The "extra free space" has become several thousand pixels for me.
(Assignee)

Updated

8 years ago
(Assignee)

Comment 3

8 years ago
Turning javascript off seems to fix the issue, so we're getting somewhere.
(In reply to comment #3)
> Turning javascript off seems to fix the issue, so we're getting somewhere.

Specifically, the category list seems at fault: Opening it, with JS enabled, makes the problem go away -- when closing it, it reappears. Looks to me like something is pushed way off to the left via JavaScript, and in an rtl environment this would need to be to the right in order to achieve the same effect while not screwing up the page.
(In reply to comment #4)
> Looks to me like something is pushed way off to the left via JavaScript...

I meant via CSS.
(Assignee)

Comment 6

8 years ago
Yeah, I figured it out:

#categories.collapsed #cat-list {
left:-999em;
position:absolute;
top:-999em;
}

I should have a fix soon.
(Assignee)

Comment 7

8 years ago
Created attachment 358307 [details] [diff] [review]
Fix for rtl languages

Here's the fix.
Attachment #358307 - Flags: review?(clouserw)
Comment on attachment 358307 [details] [diff] [review]
Fix for rtl languages

nice work
Attachment #358307 - Flags: review?(clouserw) → review+
(Assignee)

Comment 9

8 years ago
r21698
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
I don't think we/you care, but fyi, I was able to reproduce this on IE 8 in compatibility mode.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.