Cmd/Command+Shift+"[" / "]" should switch tabs on Mac

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
trivial
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: Nickolay_Ponomarev, Assigned: James Ross)

Tracking

({polish})

Trunk
x86
Mac OS X
polish

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.84])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
As in Safari, Firefox and other Mac applications.
(Assignee)

Updated

10 years ago
Version: unspecified → Trunk
(Assignee)

Comment 2

10 years ago
Created attachment 338658 [details] [diff] [review]
Add Command-Alt-Left/Right and Command-Shift-[/] shortcuts

This patch also makes the existing shortcuts stricter by requiring the unnecessary modifiers to not be pressed (e.g. Control-Shift?-Tab now requires that Alt is not pressed to work).
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #338658 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 3

10 years ago
Created attachment 338757 [details] [diff] [review]
Same but without old Command-Shift?-Tab shortcut
Attachment #338658 - Attachment is obsolete: true
Attachment #338757 - Flags: review?(gijskruitbosch+bugs)
Attachment #338658 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 4

10 years ago
Created attachment 338758 [details] [diff] [review]
Same but without old Command-Shift?-Tab shortcut

Correct patch this time!
Attachment #338757 - Attachment is obsolete: true
Attachment #338758 - Flags: review?(gijskruitbosch+bugs)
Attachment #338757 - Flags: review?(gijskruitbosch+bugs)

Comment 5

10 years ago
Comment on attachment 338758 [details] [diff] [review]
Same but without old Command-Shift?-Tab shortcut

>=== modified file 'xul/content/handlers.js'
> <snip>
>-        case 33: /* pgup */
>-            if (e.ctrlKey)
>+        case 33: /* Page Up */
>+            // Control-Page Up => previous tab (all platforms)
>+            if (e.ctrlKey && !e.altKey && !e.metaKey && !e.shiftKey)

Are we sure there are no keyboard layouts where the shift key thing will get in the way? (thinking in particular of laptop keyboards - on my macbook, page up/dn are on the arrow keys, though I think they require the Fn key rather than the shift key). I don't think it would hurt to leave that one off here. :-)
The same goes for the []/{} thing. Does that work with other layouts as well, where the {} might not be on the same key as [] ? Maybe I'm misunderstanding how keyboard layouts are represented to JS here, though.

As a second point, would it be possible to combine the code for page up/dn in a similar way as is done in the arrows and braces cases? It would reduce code duplication and hopefully improve readability, I think...


With those comments addressed, r=me ! :-)
Attachment #338758 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 6

10 years ago
At least for the []/{} thing, I could find no definitive answer on what the shortcut actually was. Some things said it was Control-{/}, others said Control-Shift-[/]. If you can find out which it officially should be, by all means do so. (Although Control-{/} is going to need quite a bit of work to that code...)
(Assignee)

Comment 7

10 years ago
Checked in with page up/down collapsed --> FIXED.
(Assignee)

Comment 8

10 years ago
F***ing new Bugzilla interface of FAIL.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.84]

Updated

5 years ago
Blocks: 856054
You need to log in before you can comment on or make changes to this bug.