439395 - %(ga-IE) "Show image" and "view image" should be translated differently

Status: RESOLVED FIXED

(Mozilla Localizations :: ga-IE / Irish, defect)

Description

[Simon Montagu :smontagu]

In browser/chrome/browser/browser.dtd there are two labels with very similar text:
<!ENTITY showImageCmd.label           "Show Image">
<!ENTITY viewImageCmd.label           "View Image">
The meaning is different: "Show Image" appears in the context menu for images that were not fully loaded, and will attempt to reload the image. "View image" loads the image stand-alone.
The translation of the two texts should be different

Comment 1

[Kevin Scannell]

Attachment: Fix for incorrect translation

Thanks for catching this, Simon.   I fixed the "Show Image" translation to, essentially, "Reload the Image" - I assume that is reasonable in this context, and tidied up two others in the same context menu for clarity/parallelism.

Comment 2

[Kevin Scannell]

Axel, when would I be allowed to check this change in?

Comment 3

[Axel Hecht [:Pike]]

Please create a patch and request approval1.9. I hope we'll be able to open up the tree to approved check-ins soon.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 325276 [details] [diff] [review]
Fix for incorrect translation

a=me, please land this with a check-in comment referencing this bug and my approval.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Please cancel the approval1.9 flag, too

Comment 5

[Kevin Scannell]

Commited to CVS:
Checking in browser.dtd;
/l10n/l10n/ga-IE/browser/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.47; previous revision: 1.46
done