439462 - Textarea does not scroll when new empty lines are added

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kai Liu]

STR:
1) Hold down [Enter] in this bug's comment box.
2) Notice that a scrollbar does not appear and the textarea does not scroll
   when the caret goes past the end.

Backing out bug 421436 fixed this for me.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should probably back out 421436 on trunk. Let me just make a build to verify.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by backing out bug 421436.

Comment 3

[Simon Montagu :smontagu]

I can't reproduce this after rechecking in bug 421436, nor have I been able to get back to a source tree which I can build and this bug appears, but if anybody can, a testcase would be good.

Comment 5

[Daniel Holbert [:dholbert]]

This cropped up again when bug 421436 was re-landed this week. It looks like the STR are slightly more nuanced than what Comment 0 describes -- the issue only happens after you've added enough newlines to create a scrollbar, and then added some text below the first scrollable "page" of the textbox.

Attachment 8427231 [details] is a (new) interactive testcase, with instructions included. We can hopefully come up with an automated testcase from that.

Comment 6

[Daniel Holbert [:dholbert]]

Resolving as FIXED by backout of bug 421436. (Technically only backed out on inbound -- not central yet -- but it'll be on central soon and presumably the merge-sheriff won't know that they should close this bug at that point, so I'm closing it ahead of time.)

Comment 7

[Simon Montagu :smontagu]

(In reply to Daniel Holbert [:dholbert] from comment #5)
> This cropped up again when bug 421436 was re-landed this week. It looks like
> the STR are slightly more nuanced than what Comment 0 describes -- the issue
> only happens after you've added enough newlines to create a scrollbar, and
> then added some text below the first scrollable "page" of the textbox.

I think it's more likely that the STR were correct when this was filed and it has morphed some time in the last six years. Not that it makes much difference at this point.