439486 - Right-clicking on an IMAP or NNTP folder, selecting Subscribe displays empty folder list

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Chris Skaryd]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008061603 Thunderbird/3.0a2pre ID:2008061603

When right clicking on an IMAP folder and selecting subscribe, the window which normally allows you to select folders to subscribe to or unsubscribe from is blank, looking like this:

+---------------------------------------+
|    Account: ========================= |
| Show items: [_______________________] |
|  _____________                        |
| |_|New Groups|_______________________ |
| |                                   | |
| | +-------------------+  Subscribe  | |
| | |                   | Unsubscribe | |
| | |                   |   Refresh   | |
| | |                   |     Stop    | |
| | |                   |             | |
| | +-------------------+             | |
| |___________________________________| |
|                                       |
+---------------------------------------+

However, right-clicking the account name and selecting Subscribe correctly populates the window with the folders.

Possibly related to Bug 428662?

Reproducible: Always

Steps to Reproduce:
1. Right-click IMAP folder
2. Select Subscribe
Actual Results:  
An empty window is displayed where folders should be

Expected Results:  
See IMAP folders with option to subscribe or unsubscribe.

I am setup with secure IMAP.  I have not tested this with an insecure server.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Confirming (Checked with Tb trunk on MS Win-XP SP2)
> Worksforme : Name=Thunderbird,Version=3.0a2pre,BuildID=2008060203
> Confirmed  : Name=Thunderbird,Version=3.0a2pre,BuildID=2008061203
> Confirmed  : Name=Thunderbird,Version=3.0a2pre,BuildID=2008061603

Comment 2

[WADA:World Anti-bad-Duping Agency]

I checked with Gmail IMAP account.

Comment 3

[Wayne Mery (:wsmwk)]

works version 3.0a2pre (2008060508)
works version 3.0a2pre (2008060603)
works version 3.0a2pre (2008060703)
fails version 3.0a2pre (2008060808)

Comment 4

[Phil Ringnalda (:philor)]

A range which neatly encapsulates bug 436630 part 1, and pretty much nothing else.

Comment 5

[Joey Minta]

Attachment: patch [Checkin: Comment 7]

The error console includes the message "can't find folder to select."  It'd be really helpful for people to check that when filing rdf-regression bugs.  That error happens because we try to select the child folder, but the menu only handles accounts.  This patch forces us to select root-folders only.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 325650 [details] [diff] [review]
patch
[Checkin: Comment 7]

Since this is a regression, r=dmose for this patch, conditional on:

a) since the selection code in SetUpServerMenu no longer works, just get rid of that function entirely and call SetServerTypeSpecificTextValues directly instead.  The fact that we're no longer explicitly selecting anything in the case where a caller doesn't pass in preselectedURI is probably ok, though it's possible that someone else watching this bug knows differently.

b) file a bug to sort out what the UX here should be.  The idea that an item in the context menu for a folder should be operating on something other than the folder itself strikes me as bizarre and probably wrong.

c) file a bug on cleaning up SubscribeOnLoad to actually be readable & maintainable

Comment 7

[Joey Minta]

Patch checked in, leaving bug open to handle follow-up stuff tomorrow.
Checking in mail/base/content/subscribe.js;
/cvsroot/mozilla/mail/base/content/subscribe.js,v  <--  subscribe.js
new revision: 1.16; previous revision: 1.15
done

Comment 8

[Chris Skaryd]

As the original reporter, this is working for me now with 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1pre) Gecko/2008062403 Thunderbird/3.0a2pre ID:2008062403

Comment 9

[Joey Minta]

Bug 441704 and Bug Bug 441705 have been filed as dmose requested.  Closing this bug.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> A range which neatly encapsulates bug 436630 part 1

Ftr, the line fixed by the patch here is from bug 413781 (which landed much earlier than this regression):
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/base/content/subscribe.js&rev=HEAD&mark=1.16,1.14#1.17
SeaMonkey will port the latter in bug 444913.