439500 - Dev Tools allow install.rdf with 3.* as maxVersion

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Basil Hashem [:baz]]

We should not be allowing "3.*" as a valid maxversion.

e.g. Symbaloo Bookmarker 0.7 (https://addons.mozilla.org/en-US/firefox/addon/6885)

https://addons.mozilla.org/en-US/firefox/downloads/file/30666/symbaloo_bookmarker-0.7-.xpi includes the invalid maxVer in the install.rdf

Comment 1

[Basil Hashem [:baz]]

I should also note that this page (https://addons.mozilla.org/en-US/editors/review/47189) has blank compatibility fields in the upper right area

Comment 2

[Michael Morgan [:morgamic]]

Alternatively, what do we allow, then?  3.0.*?

Comment 3

[Justin Scott [:fligtar]]

I'll look into this - it's like the versions weren't checked at all.

Comment 5

[Justin Scott [:fligtar]]

Attachment: patch, v1

The target app validation function was changed with 3.5 and I forgot to make a needed change to the old Dev CP. This will now catch the errors that it's been throwing.

After this is pushed live I can do a query and update the target app info for all the add-ons that were affected by this.

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 325478 [details] [diff] [review]
patch, v1

Looks ok to me, check it in.

Comment 7

[Justin Scott [:fligtar]]

Thanks, checked in r16059

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Does this fix also fixes the extensions which are already public?
1. They are "hidden" at the moment, you can't find them by searching (try "Pterodactl").
2. They aren't shipped as updates.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Any chances to check the database for approved add-ons with this problem? They still exist.

Comment 10

[Justin Scott [:fligtar]]

3.4.5 was pushed on Friday.