439588 - When firefox is in offline mode at startup, weave asks the user for the password

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Experiencing with weave 0.1.30


STR:
* unplug network cable/disconnect network
* start minefield (minefield automatically goes into offline mode)


Results:
* Weave asks the user for his password, the fields are prefilled.


Expected:
* Weave should recognize offline mode and display "Offline" as the status
* When the connection is back, weave should log in

Comment 1

[Aiing]

Very similar use case that I dont think is worth filing a seperate bug for:

On launch of firefox in certain locations I have to switch my proxy. 

Weave will always promt for login credentails even if services.mozilla.com is unreachable. 
If Weave cannot reach services.mozilla.com it should fail silently and not prompt for login creadentials.

Maybe just change the Staus bar inidcator to show the website is unreachable.

Comment 2

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 3

[Ed Lee :Mardak]

We should be able to just check Svc.IO.offline and perhaps yield the current function, e.g., yield or login, and have it continue when we get "network:offline-status-changed" topic with data "online".

Not sure if we should show "Offline" in the status bar. Or if we do, make sure we disable the Sign In option.

This would be useful for handling private browsing too.

Comment 5

[Ed Lee :Mardak]

http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#166

for the offline/online topic and data values.

http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIPrivateBrowsingService.idl#87

for private browsing enter/exit notifications.

Comment 6

[Mike Connor [:mconnor]]

This is WFM now, suspect this was fixed by making the autoconnect call cycle until we can actually log in.