439720 - MozillaBuild 1.3: unexpected: 5 due to empty SDKVER in start-msvc8.bat

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Nickolay_Ponomarev]

MozillaBuild 1.3, start-msvc8.bat, VS2005, Vista Home Premium:

lines 54-55:
    rem If the SDK is Win2k3SP2 or higher, we want to use it
    if %SDKVER% GEQ 5 (

SDKVER is empty, so I get a syntax error, something like "unexpected occurrence: 5", I guess (rough translation from Russian).

Comment 1

[(not currently active) Ted Mielczarek]

http://mxr.mozilla.org/mozilla/source/tools/build-environment/win32/guess-msvc.bat#77

guess-msvc.bat initializes this to 0, so I don't see how this happens.

Comment 2

[Nickolay_Ponomarev]

SDKDIR, PSDKDIR, and PSDKVER are all empty, so SDKVER is cleared here:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/tools/build-environment/win32/guess-msvc.bat&rev=1.10&mark=111-113#111

Let me know if you need to know anything else. MozillaBuild 1.2 works, as does 1.3 if I fix the syntax error.

Comment 3

[(not currently active) Ted Mielczarek]

Ah, are you using VC8 Pro without an external SDK?

Comment 4

[Sylvain Pasche]

Same error here. I've quoted the variable to prevent the error, I'll see if my build succeeds. I don't remember having installed an external SDK.

Comment 5

[Sylvain Pasche]

I forgot to add that I'm on XP with VS2005.

Comment 7

[Christoph Tapler]

I had the same issue. Indeed, it happens if the SDK is not installed. I just tried to put the %SDKVER% into quotes and then the batch file ran through and told me (which was right at that time) that the SDK is missing. After installation of the SDK the processing of the batch file was still okay. 
However, I am not familiar with batch files and I don't know if the quotes around %SDKVER% actually fixes the issue.

Comment 8

[Samuel Monsarrat]

Same here, I just have vs2005 installed, no SDK, not needed with the full version of vs2005.
Adding quotes around %SDKVER% solves the problem.

Comment 9

[(not currently active) Ted Mielczarek]

Pushed a fix:
http://hg.mozilla.org/mozilla-build/rev/e87febbbb6bd
will wind up in MozillaBuild 1.4.