43999 - need to make xptlink.pl cross-platform

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jon Granrose]

xptlink is a script used to merge multiple .xpt files into one as part of the 
packaging process to improve browser startup time.  We currently have one 
version that is checked in to mozilla/xpinstall/packager that runs on win32 and 
unix and another version that is not checked in that runs on the mac.

we need to merge the changes from the mac version into the checked in version so 
that we have a single xptlink that works on all platforms.

Comment 1

[Jon Granrose]

fix tested and checked in for win32 and linux.  still have to test on mac before 
turning on for mac.

Comment 2

[Jon Granrose]

jj and I worked on this the day before and checked in the fixes.

resolved/fixed.  I'll leave it to jj to verify that the mac is using that
xptlink.pl and everything is working correctly.

Comment 3

[J.J. Enser]

Looking at today's M18 build, xpt files got merged ok. Today's perl log sez:

Linking .xpt files...
[FullCircle]
[SpellChecker]
[artextensions]
[browser]
# Warning:  file browser.xpt already exists.
# Warning:  file browser.xpt already exists.
[chatzilla]
[deflenus]
[flash]
[langende]
[langenus]
[langjajp]
[mail]
# Warning:  file mail.xpt already exists.
# Warning:  file mail.xpt already exists.
[nim]
[xpcom]
Linking .xpt files completed.

---

Jon, if you feel ok with the duplicate "... alreday exists" lines above, then be 
my guest and marked this puppy verified.

Comment 4

[Jon Granrose]

verified.  you're probably doing the staging for the mozilla and ns bits in the
same area, so it copies in the new files and the browser.xpt file from the
mozilla build is still there.  It shouldn't be adding things that are already in
the file, so it shouldn't be causing any problems.

Comment 5

[J.J. Enser]

Agreed, and I always had these "already exists" warnings before, but not TWICE 
for each module like it happens now. That's what I wanted to point out.