44003 - nsBrowserWindow leaks gTiTleSuffix

Status: RESOLVED FIXED

(Core Graveyard :: Viewer App, defect, P3)

Description

[carl.wong]

There is an nsString gTitleSuffix in nsBrowserWindow.cpp and it was never 
freed.  It is a very minor problem but fixing this will reduce noise in the 
bloatview log when using viewer as the testing tool.

Comment 1

[carl.wong]

Attachment: The patch will free the memory allocated for gTitleSuffix

Comment 2

[Bruce Mitchener]

is anything stopping this from getting checked in?

Comment 3

[Kevin Higgins]

Attachment: update patch to apply to current CVS

Comment 4

[Kevin Higgins]

I created a new diff to the orig. patch, as it was 7 months old and wouldn't
apply to current CVS.  This is an easy fix.  Can someone look at it, for an r=?

cc'ing [e-mail]

Comment 5

[Brendan Eich [:brendan]]

viewer changes can go in with one level of review, maybe.  Cc'ing buster.

/be

Comment 6

[buster]

yes, I agree that viewer changes can go in with a single reviewer from the
layout team.  I'll add a note to the newsgroup to that effect.  r=buster, please
check it in when you can.  If you don't have cvs access, I'd be happy to get it
in for you.

Comment 7

[Kevin Higgins]

I don't have CVS access, so could you check this in buster?  Thanks.

Comment 8

[buster]

assigning to marc so he can check this in

Comment 9

[Marc Attinasi]

Okey Dokey. Will check in when the tree opens.

Comment 10

[Marc Attinasi]

Fix checked in. Thanks Kevin!