440076 - checkInterfaceMethodOverrides is a performance problem

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Tommy Reilly]

A sampling of starting a Flex app shows %95 of the time under this method.    There's some kind of combinatorial nightmare happening here...

Comment 1

[Tommy Reilly]

Maybe we need to remember work we've done during TraitsData loading?   Like we should only have to "check" things about a type once, not everytime a type is loaded into the cache, like flags on TraitsEnv could record work done already.    Maybe not directly related to this bug but might be a future work item, I see Flex apps causing a fair amount of churn in that 32 item cache.

Comment 2

[Steven Johnson]

I think the code is just insanely stupid, doing many redundant rechecks. It wasn't a factor in shallow inheritance hierarchies so we didn't notice it. Working on a fix now.

Comment 3

[Steven Johnson]

Attachment: Patch

Tommy, I'm still testing this fix but I think it greatly improves the situation... try it and see if it helps.

(Also includes two unrelated fixes to avm.cpp and WeakRef that will be documented momentarily)

Comment 4

[Steven Johnson]

Comment on attachment 325609 [details] [diff] [review]
Patch

just found a flaw, hold on...

Comment 5

[Steven Johnson]

Attachment: Patch

Same as before, but fix an incorrect assert, avoid redundant generation of TraitsData, and enlarge the TraitsData cache.

Comment 6

[Steven Johnson]

changeset:   416:10d6a6e15441