440156 - garburator: classes with multiple user attributes are not correctly identified as stack classes

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

class __attribute__((user("NS_stack"))) is identified as a stack class to be rewritten.

class __attribute__((user("NS_foo"))) __attribute__((user("NS_stack"))) is not.

As a testcases, add the extra attribute to http://hg.mozilla.org/oink/index.cgi/file/5f83b1ad8462/garburator_tests/longevity.cc#l180

Comment 1

[(dormant account)]

Attachment: Multi-attribute support

Give this a try. I didn't consider multiple attribute case when implementing this.

Comment 2

[Benjamin Smedberg]

Comment on attachment 326338 [details] [diff] [review]
Multi-attribute support

>diff --git a/garburator.cc b/garburator.cc

>+        AT_func attrFunc = asl->spec->attr->asAT_func();

Patched this to be AT_func *attrFunc, and it works. I'll push it with this change.

Comment 3

[(dormant account)]

Good eye. It's a little frustrating that elsa allows things like that to slip.