440286 - Add Thunderbird UI for System Proxy Settings (port firefox bug 416274)

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Matthew]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9) Gecko/2008061810 (Gentoo) Firefox/3.0
Build Identifier: version 2.0.0.14 (20080607)

Background: I have to tunnel all my data through a SOCKS proxy while at school.

Firefox allows me to use "Use System Proxy Settings", which seems to snatch the proxy from GNOME, while Thunderbird has no matching option.

Reproducible: Always

Steps to Reproduce:
1. Edit --> Preferences --> Advanced --> Network & Disk Space --> Connection
2. 
3.
Actual Results:  
No visible option for System Proxy settings...

Expected Results:  
Option for System Proxy settings!

Using Gentoo with GNOME

Comment 1

[Magnus Melin [:mkmelin]]

Confirming. Have a patch.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This patch ports firefox bug 416274 (the backend work was bug 66057).

I only tested HTTP proxy, by going to Gnome: System | Preferences | Network proxy and setting http proxy to example.com which does take effect, so it should all work fine, and we only have to add the UI.

(Porting ff bug 413993 string changes also included in the patch.)

Comment 3

[Magnus Melin [:mkmelin]]

Oh, I mentioned that mainly because export http_proxy="http://proxy.example.com:8079/" didn't take effect for me (under kde) for some reason. Maybe the gconf settings trumps it...

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: screenshots

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 326114 [details] [diff] [review]
proposed fix

Nice.

Comment 6

[Magnus Melin [:mkmelin]]

Checking in mail/components/preferences/connection.js;
/cvsroot/mozilla/mail/components/preferences/connection.js,v  <--  connection.js
new revision: 1.7; previous revision: 1.6
done
Checking in mail/components/preferences/connection.xul;
/cvsroot/mozilla/mail/components/preferences/connection.xul,v  <--  connection.xul
new revision: 1.8; previous revision: 1.7
done
Checking in mail/locales/en-US/chrome/messenger/preferences/connection.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/preferences/connection.dtd,v  <--  connection.dtd
new revision: 1.6; previous revision: 1.5
done

->FIXED