440294 - Firefox sometimes crashes when downloading/saving file

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[Peter Weilbacher]

As reported in mozilla.dev.ports.os2 by Elbert Pol Firefox 3.0 on OS/2 crashes sometimes when saving/downloading a file. I have experienced the same, although it's not really reproducible.

Console output looks like this:

Killed by SIGSEGV
pid=0x0096 ppid=0x002f tid=0x0001 slot=0x009c pri=0x0200 mc=0x0001
C:\PROGRAMS\FIREFOX\FIREFOX.EXE
LIBC063 ffffffff:ffffffff
cs:eip=005b:217744b1      ss:esp=0053:0011d6c8      ebp=0011d864
  ds=0053      es=0053      fs=150b      gs=0000     efl=00210a96
eax=ff00000b ebx=216ade08 ecx=00000000 edx=217743d8 edi=00000000 
esi=00000000
Process dumping was disabled, use DUMPPROC / PROCDUMP to enable it.

so it's basically useless but I guess it's an OS/2 specific problem.

Comment 1

[Shawn Wilsher :sdwilsh]

Hey Peter,

Could you get a backtrace so I can try to figure out what's up?

Comment 2

[Peter Weilbacher]

It's not as easy on OS/2 as it is on Linux to take a backtrace, but I'm going to make a debug build to do that.

Comment 3

[Peter Weilbacher]

Attachment: debugger output

OK, created a debug build and managed to reproduce it running under the debugger a few times. But I'm not sure that I get accurate information. As can be seen from this attachment, the member variables involved have a very unlikely address of 0xDDDDDDDD. If it is true, however, then the crash occurred in nsCachedStyleData::GetStyleContent(), the debugger put me onto the line coming
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/style/nsStyleStructList.h&rev=3.14&mark=105#105
which is included into layout/style/nsRuleNode.cpp several times with different settings.

Before running under the debugger, I got the crash from the debug build with console output and saw that it occurred in GKLAYOUT.DLL. So maybe the debugger crash is different from the non-debug build which crashed in the C library... But still, could very well be that this has nothing to do with the download manager, storage or SQLite as I had first suspected.

Comment 4

[Peter Weilbacher]

Hmm, I haven't been able to make it crash in the last weeks. Since I added the last comment I have downloaded tons of stuff and it hasn't crashed since...

Comment 5

[Martin Sch]

Very often it crashes when I click on a PDF link. The PDF loads and displays in lucide, but firefox is gone.

Comment 6

[Peter Weilbacher]

jms, do you see similar console output after the crash as in comment 0? With a crash in LIBC063.DLL or do you see another DLL listed? Have you seen it for images at all?

I downloaded a few PDFs, also viewed them in Lucide, and it worked without crashes. I should perhaps not that when I still experienced the crashes when downloading images I saw that the files were downloaded just fine.

Comment 7

[Martin Sch]

I started from command prompt, clicked on a PDF file, firefox crashed but there was no output in the console.

I then created a fresh profile, copied my old prefs.js into it: no crash.
I started with normal profile in -safe-mode: no crash
I started with normal profile in normal mode: no crash any more!?

Comment 8

[Peter Weilbacher]

I hate bugs that vanish while investigating them...

If you try again to capture console output, you may have to redirect the stderr output, like this:
   firefox.exe > output.log 2>&1

At least we can now assume that it is some setting in the profile which triggers this bug.

Comment 9

[Martin Sch]

I did not modify my original profile.
All I did was starting FF with -safe-mode one time.
Maybe that did something which solved the problem.

If others experience the crash, they may try to start FF once with -safe-mode.

Comment 10

[Peter Weilbacher]

I haven't seen the crash any more in the last weeks and haven't seen anybody else complaining, so I'm resolving this WFM. We can always reopen, if we get more evidence.

Comment 11

[Peter Weilbacher]

OK, so this seems to be more frequent with FF 3.0.3, so I reopen it.

Comment 12

[Peter Weilbacher]

I haven't seen this problem with Firefox 3.5.x any more. Should we resolve it as WORKSFORME? Or has anyone still seen this?

Comment 13

[Martin Sch]

Works for me...

JMS

Comment 14

[Marcus O.]

Crashes frequently with Firefox 3.6 Beta 4 under Fedora Core 10

Comment 15

[Wayne Mery (:wsmwk)]

WFM per comments 12 and 13. 
Marcus, if you still see crash, please file new bug with stacktrace