440609 - Implement Bugzilla::Bug->check for use instead of ValidateBugId

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

Most objects in Bugzilla have a check() function that determines all of the validation about that object when you create it--for example, that you passed in a valid id, that the object isn't undef, that you can see the object, etc.

However, for bugs we're still using the ancient ValidateBugId subroutine. We should have a Bugzilla::Bug->check and be using this instead.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here's a simple version of Bug->check to start out with, and a simple use of it in one file.

Comment 2

[Frédéric Buclin]

Comment on attachment 325889 [details] [diff] [review]
v1

Looks good. r=LpSolit

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.243; previous revision: 1.242
done
Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.13; previous revision: 1.12
done

Comment 4

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.