Closed Bug 440675 Opened 12 years ago Closed 12 years ago

add USE_EXTENSION_MANIFEST coverage to jar.mn tests

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

Details

Attachments

(1 file)

When creating the tests for make-jars.pl and enemies of that, I didn't add a test for what happens to chrome.manifest instead of test.manifest, when specifying USE_EXTENSION_MANIFEST. Do that.

As it really only impacts what the manifest file looks like, I'm just doing this for one of the output formats.

The reference manifest is really the same as http://mxr.mozilla.org/mozilla-central/source/config/tests/test.manifest.flat, just with "chrome/" added to reference the files with the right path.

Tested on mac and win this time :-).

Ted, if you have a suggestion on how to spread my review requests a bit better, I'm all ears.
Attachment #325949 - Flags: review?(ted.mielczarek)
Comment on attachment 325949 [details] [diff] [review]
add a test to cover USE_EXTENSION_MANIFEST

Just keep the reviews coming my way, that's fine with me.
Attachment #325949 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/index.cgi/rev/9756a45384e6, FIXED.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.